* [patch] ssb: fix build failure
2007-10-15 13:50 ` [build bug] drivers/ssb " Ingo Molnar
@ 2007-10-15 13:56 ` Ingo Molnar
0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2007-10-15 13:56 UTC (permalink / raw)
To: Michael Buesch
Cc: Al Viro, gregkh, David Brownell, John W. Linville, linux-kernel
* Ingo Molnar <mingo@elte.hu> wrote:
> have triggered a new SSB build failure meanwhile:
>
> drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
> : undefined reference to `pcmcia_access_configuration_register'
the patch below fixes it for me. PCI seems to have a similar bug as
well.
Ingo
----------------->
Subject: ssb: fix build failure
From: Ingo Molnar <mingo@elte.hu>
fix build failure if PCMCIA=m but SSB=y:
drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'
(fix symmetric bug for PCI too.)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/ssb/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/ssb/Kconfig
===================================================================
--- linux.orig/drivers/ssb/Kconfig
+++ linux/drivers/ssb/Kconfig
@@ -22,7 +22,7 @@ config SSB
config SSB_PCIHOST_POSSIBLE
bool
- depends on SSB && PCI
+ depends on SSB && (PCI = SSB)
default y
config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
config SSB_PCMCIAHOST_POSSIBLE
bool
- depends on SSB && PCMCIA && EXPERIMENTAL
+ depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
default y
config SSB_PCMCIAHOST
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch] ssb: fix build failure
@ 2007-10-15 14:23 Michael Buesch
2007-10-15 15:06 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Michael Buesch @ 2007-10-15 14:23 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, bcm43xx-dev, Ingo Molnar
From: Ingo Molnar <mingo@elte.hu>
fix build failure if PCMCIA=m but SSB=y:
drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'
(fix symmetric bug for PCI too.)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
drivers/ssb/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/ssb/Kconfig
===================================================================
--- linux.orig/drivers/ssb/Kconfig
+++ linux/drivers/ssb/Kconfig
@@ -22,7 +22,7 @@ config SSB
config SSB_PCIHOST_POSSIBLE
bool
- depends on SSB && PCI
+ depends on SSB && (PCI = SSB)
default y
config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
config SSB_PCMCIAHOST_POSSIBLE
bool
- depends on SSB && PCMCIA && EXPERIMENTAL
+ depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
default y
config SSB_PCMCIAHOST
-------------------------------------------------------
--
Greetings Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ssb: fix build failure
2007-10-15 14:23 [patch] ssb: fix build failure Michael Buesch
@ 2007-10-15 15:06 ` Randy Dunlap
2007-10-15 15:10 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2007-10-15 15:06 UTC (permalink / raw)
To: Michael Buesch; +Cc: John Linville, linux-wireless, bcm43xx-dev, Ingo Molnar
On Mon, 15 Oct 2007 16:23:04 +0200 Michael Buesch wrote:
> From: Ingo Molnar <mingo@elte.hu>
>
> fix build failure if PCMCIA=m but SSB=y:
>
> drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
> : undefined reference to `pcmcia_access_configuration_register'
>
> (fix symmetric bug for PCI too.)
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
> drivers/ssb/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/ssb/Kconfig
> ===================================================================
> --- linux.orig/drivers/ssb/Kconfig
> +++ linux/drivers/ssb/Kconfig
> @@ -22,7 +22,7 @@ config SSB
>
> config SSB_PCIHOST_POSSIBLE
> bool
> - depends on SSB && PCI
> + depends on SSB && (PCI = SSB)
> default y
>
> config SSB_PCIHOST
> @@ -37,7 +37,7 @@ config SSB_PCIHOST
>
> config SSB_PCMCIAHOST_POSSIBLE
> bool
> - depends on SSB && PCMCIA && EXPERIMENTAL
> + depends on SSB && (PCMCIA = SSB) && EXPERIMENTAL
> default y
>
> config SSB_PCMCIAHOST
That's usually done more like this:
depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
This allows PCMCIA to be y or m, but if PCMCIA is m, then
SSB is restricted to m as well (or n).
I.e., PCMCIA = SSB is too strict and not required.
or am I not seeing straight?
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ssb: fix build failure
2007-10-15 15:06 ` Randy Dunlap
@ 2007-10-15 15:10 ` Ingo Molnar
2007-10-15 15:14 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2007-10-15 15:10 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Michael Buesch, John Linville, linux-wireless, bcm43xx-dev
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> That's usually done more like this:
>
> depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
>
> This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is
> restricted to m as well (or n). I.e., PCMCIA = SSB is too strict and
> not required.
indeed - updated patch below.
Ingo
------------------>
From: Ingo Molnar <mingo@elte.hu>
fix build failure if PCMCIA=m but SSB=y:
drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
: undefined reference to `pcmcia_access_configuration_register'
(fix symmetric bug for PCI too.)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
drivers/ssb/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/drivers/ssb/Kconfig
===================================================================
--- linux.orig/drivers/ssb/Kconfig
+++ linux/drivers/ssb/Kconfig
@@ -22,7 +22,7 @@ config SSB
config SSB_PCIHOST_POSSIBLE
bool
- depends on SSB && PCI
+ depends on SSB && (PCI = y || PCI = SSB)
default y
config SSB_PCIHOST
@@ -37,7 +37,7 @@ config SSB_PCIHOST
config SSB_PCMCIAHOST_POSSIBLE
bool
- depends on SSB && PCMCIA && EXPERIMENTAL
+ depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
default y
config SSB_PCMCIAHOST
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] ssb: fix build failure
2007-10-15 15:10 ` Ingo Molnar
@ 2007-10-15 15:14 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2007-10-15 15:14 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Michael Buesch, John Linville, linux-wireless, bcm43xx-dev
Ingo Molnar wrote:
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> That's usually done more like this:
>>
>> depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
>>
>> This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is
>> restricted to m as well (or n). I.e., PCMCIA = SSB is too strict and
>> not required.
>
> indeed - updated patch below.
>
> Ingo
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ------------------>
> From: Ingo Molnar <mingo@elte.hu>
>
> fix build failure if PCMCIA=m but SSB=y:
>
> drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
> : undefined reference to `pcmcia_access_configuration_register'
>
> (fix symmetric bug for PCI too.)
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
> drivers/ssb/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/ssb/Kconfig
> ===================================================================
> --- linux.orig/drivers/ssb/Kconfig
> +++ linux/drivers/ssb/Kconfig
> @@ -22,7 +22,7 @@ config SSB
>
> config SSB_PCIHOST_POSSIBLE
> bool
> - depends on SSB && PCI
> + depends on SSB && (PCI = y || PCI = SSB)
> default y
>
> config SSB_PCIHOST
> @@ -37,7 +37,7 @@ config SSB_PCIHOST
>
> config SSB_PCMCIAHOST_POSSIBLE
> bool
> - depends on SSB && PCMCIA && EXPERIMENTAL
> + depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
> default y
>
> config SSB_PCMCIAHOST
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-15 15:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 14:23 [patch] ssb: fix build failure Michael Buesch
2007-10-15 15:06 ` Randy Dunlap
2007-10-15 15:10 ` Ingo Molnar
2007-10-15 15:14 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2007-10-14 3:29 [bug] usb build failure, latest -git Ingo Molnar
2007-10-14 3:35 ` Al Viro
2007-10-15 10:53 ` Ingo Molnar
2007-10-15 12:58 ` Michael Buesch
2007-10-15 13:50 ` [build bug] drivers/ssb " Ingo Molnar
2007-10-15 13:56 ` [patch] ssb: fix build failure Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.