* unregister_xenbus_watch() handling of xenwatch_mutex
@ 2007-10-18 11:38 Jan Beulich
2007-10-18 12:12 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2007-10-18 11:38 UTC (permalink / raw)
To: xen-devel
2.6.23 acquires the mutex before canceling pending events, whereas
linux-2.6.18-xen acquires and releases the mutex back-to-back after
doing the cancellation. It would seem to me that the former method is
more robust, but otoh I'm wondering why this change then wasn't also
made in the 2.6.18 tree.
Thanks, Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unregister_xenbus_watch() handling of xenwatch_mutex
2007-10-18 11:38 unregister_xenbus_watch() handling of xenwatch_mutex Jan Beulich
@ 2007-10-18 12:12 ` Keir Fraser
2007-10-18 16:02 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2007-10-18 12:12 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Jeremy Fitzhardinge
That's a question for Jeremy. I think the 2.6.18 version is equally correct
and only needs one if statement. Maybe hoisting the lock acquisition gave
Jeremy a warmer fuzzy feeling? :-)
-- Keir
On 18/10/07 12:38, "Jan Beulich" <jbeulich@novell.com> wrote:
> 2.6.23 acquires the mutex before canceling pending events, whereas
> linux-2.6.18-xen acquires and releases the mutex back-to-back after
> doing the cancellation. It would seem to me that the former method is
> more robust, but otoh I'm wondering why this change then wasn't also
> made in the 2.6.18 tree.
>
> Thanks, Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unregister_xenbus_watch() handling of xenwatch_mutex
2007-10-18 12:12 ` Keir Fraser
@ 2007-10-18 16:02 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2007-10-18 16:02 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel, Jeremy Fitzhardinge, Jan Beulich
Keir Fraser wrote:
> That's a question for Jeremy. I think the 2.6.18 version is equally correct
> and only needs one if statement. Maybe hoisting the lock acquisition gave
> Jeremy a warmer fuzzy feeling? :-)
>
I don't remember changing this specifically. It might have been in
response to a review comment, or maybe xen-unstable changed since I
grabbed the code...
J
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-18 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-18 11:38 unregister_xenbus_watch() handling of xenwatch_mutex Jan Beulich
2007-10-18 12:12 ` Keir Fraser
2007-10-18 16:02 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.