[lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Hi Mark & All,

This patch adds support for 2 new motherboards to the abituguru3 driver. Its a 
pretty trivial patch and it would be nice if this could make 2.6.24.

Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Thnaks & Regards,

Hans

[-- Attachment #2: hwmon-abituguru3-new-motherboards.patch --]
[-- Type: text/x-patch, Size: 2427 bytes --]

This patch adds support for 2 new motherboards to the abituguru3 driver.

Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -up linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c~ linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c
--- linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c~	2007-10-19 21:01:23.000000000 +0200
+++ linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c	2007-10-19 21:01:23.000000000 +0200
@@ -530,6 +530,58 @@ static const struct abituguru3_motherboa
 		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
 		{ NULL, 0, 0, 0, 0, 0 } }
 	},
+	{ 0x001B, "unknown", {
+		{ "CPU Core",		 0, 0, 10, 1, 0 },
+		{ "DDR3",		 1, 0, 20, 1, 0 },
+		{ "DDR3 VTT",		 2, 0, 10, 1, 0 },
+		{ "CPU VTT",		 3, 0, 10, 1, 0 },
+		{ "MCH 1.25V",		 4, 0, 10, 1, 0 },
+		{ "ICHIO 1.5V",		 5, 0, 10, 1, 0 },
+		{ "ICH 1.05V",		 6, 0, 10, 1, 0 },
+		{ "ATX +12V (24-Pin)",	 7, 0, 60, 1, 0 },
+		{ "ATX +12V (8-pin)",	 8, 0, 60, 1, 0 },
+		{ "ATX +5V",		 9, 0, 30, 1, 0 },
+		{ "+3.3V",		10, 0, 20, 1, 0 },
+		{ "5VSB",		11, 0, 30, 1, 0 },
+		{ "CPU",		24, 1, 1, 1, 0 },
+		{ "System",		25, 1, 1, 1, 0 },
+		{ "PWM Phase1",		26, 1, 1, 1, 0 },
+		{ "PWM Phase2",		27, 1, 1, 1, 0 },
+		{ "PWM Phase3",		28, 1, 1, 1, 0 },
+		{ "PWM Phase4",		29, 1, 1, 1, 0 },
+		{ "PWM Phase5",		30, 1, 1, 1, 0 },
+		{ "CPU Fan",		32, 2, 60, 1, 0 },
+		{ "SYS Fan",		34, 2, 60, 1, 0 },
+		{ "AUX1 Fan",		33, 2, 60, 1, 0 },
+		{ "AUX2 Fan",		35, 2, 60, 1, 0 },
+		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
+	},
+	{ 0x001C, "unknown", {
+		{ "CPU Core",		 0, 0, 10, 1, 0 },
+		{ "DDR2",		 1, 0, 20, 1, 0 },
+		{ "DDR2 VTT",		 2, 0, 10, 1, 0 },
+		{ "CPU VTT",		 3, 0, 10, 1, 0 },
+		{ "MCH 1.25V",		 4, 0, 10, 1, 0 },
+		{ "ICHIO 1.5V",		 5, 0, 10, 1, 0 },
+		{ "ICH 1.05V",		 6, 0, 10, 1, 0 },
+		{ "ATX +12V (24-Pin)",	 7, 0, 60, 1, 0 },
+		{ "ATX +12V (8-pin)",	 8, 0, 60, 1, 0 },
+		{ "ATX +5V",		 9, 0, 30, 1, 0 },
+		{ "+3.3V",		10, 0, 20, 1, 0 },
+		{ "5VSB",		11, 0, 30, 1, 0 },
+		{ "CPU",		24, 1, 1, 1, 0 },
+		{ "System",		25, 1, 1, 1, 0 },
+		{ "PWM Phase1",		26, 1, 1, 1, 0 },
+		{ "PWM Phase2",		27, 1, 1, 1, 0 },
+		{ "PWM Phase3",		28, 1, 1, 1, 0 },
+		{ "PWM Phase4",		29, 1, 1, 1, 0 },
+		{ "PWM Phase5",		30, 1, 1, 1, 0 },
+		{ "CPU Fan",		32, 2, 60, 1, 0 },
+		{ "SYS Fan",		34, 2, 60, 1, 0 },
+		{ "AUX1 Fan",		33, 2, 60, 1, 0 },
+		{ "AUX2 Fan",		35, 2, 60, 1, 0 },
+		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
+	},
 	{ 0x0000, NULL, { { NULL, 0, 0, 0, 0, 0 } } }
 };
 

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[Jean Delvare]

On Fri, 19 Oct 2007 21:06:47 +0200, Hans de Goede wrote:
> Hi Mark & All,
> 
> This patch adds support for 2 new motherboards to the abituguru3 driver. Its a 
> pretty trivial patch and it would be nice if this could make 2.6.24.
> 
> Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Acked-by: Jean Delvare <khali@linux-fr.org>

Out of curiosity, what's the plan to get the actual board names instead
of "unknown"? Shouldn't you ask people to report (e.g. in
Documentation/hwmon/abituguru3) when their board is listed as unknown?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[Jean Delvare]

On Sat, 20 Oct 2007 11:47:29 +0200, Jean Delvare wrote:
> On Fri, 19 Oct 2007 21:06:47 +0200, Hans de Goede wrote:
> > Hi Mark & All,
> > 
> > This patch adds support for 2 new motherboards to the abituguru3 driver. Its a 
> > pretty trivial patch and it would be nice if this could make 2.6.24.
> > 
> > Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>

Err, I take that back. The patch doesn't even build! List terminators
are missing, and thankfully closing curly braces do as well, otherwise
I wouldn't have noticed.

Hans, when you send patches and insist on having them pushed to Linus
quickly, you should at least make sure they build and don't cause any
regression on your own system. Obviously you didn't do that this time :(

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[Hans de Goede]

Jean Delvare wrote:
> On Sat, 20 Oct 2007 11:47:29 +0200, Jean Delvare wrote:
>> On Fri, 19 Oct 2007 21:06:47 +0200, Hans de Goede wrote:
>>> Hi Mark & All,
>>>
>>> This patch adds support for 2 new motherboards to the abituguru3 driver. Its a 
>>> pretty trivial patch and it would be nice if this could make 2.6.24.
>>>
>>> Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
>> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> Err, I take that back. The patch doesn't even build! List terminators
> are missing, and thankfully closing curly braces do as well, otherwise
> I wouldn't have noticed.
> 
> Hans, when you send patches and insist on having them pushed to Linus
> quickly, you should at least make sure they build and don't cause any
> regression on your own system. Obviously you didn't do that this time :(
> 

Oops,

You are fully right, I was doing a zillion things at once, and didn't test 
build this before sending the patch. My bad, aplogies!

I'll do a new version asap.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[lm-sensors] PATCH: hwmon-abituguru3-new-motherboards-v2.patch

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi All,

This patch adds support for 2 new motherboards to the abituguru3 driver. This
time with list terminators and closing brackets, sorry about the bad previous
patch.

Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Regards,

Hans

[-- Attachment #2: hwmon-abituguru3-new-motherboards-v2.patch --]
[-- Type: text/x-patch, Size: 2575 bytes --]

This patch adds support for 2 new motherboards to the abituguru3 driver. This
time with list terminators and closing brackets, sorry about the bad previous
patch.

Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -up linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c~ linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c
--- linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c~	2007-10-21 00:47:36.000000000 +0200
+++ linux-2.6.23.x86_64/drivers/hwmon/abituguru3.c	2007-10-21 00:47:36.000000000 +0200
@@ -530,6 +530,60 @@ static const struct abituguru3_motherboa
 		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
 		{ NULL, 0, 0, 0, 0, 0 } }
 	},
+	{ 0x001B, "unknown", {
+		{ "CPU Core",		 0, 0, 10, 1, 0 },
+		{ "DDR3",		 1, 0, 20, 1, 0 },
+		{ "DDR3 VTT",		 2, 0, 10, 1, 0 },
+		{ "CPU VTT",		 3, 0, 10, 1, 0 },
+		{ "MCH 1.25V",		 4, 0, 10, 1, 0 },
+		{ "ICHIO 1.5V",		 5, 0, 10, 1, 0 },
+		{ "ICH 1.05V",		 6, 0, 10, 1, 0 },
+		{ "ATX +12V (24-Pin)",	 7, 0, 60, 1, 0 },
+		{ "ATX +12V (8-pin)",	 8, 0, 60, 1, 0 },
+		{ "ATX +5V",		 9, 0, 30, 1, 0 },
+		{ "+3.3V",		10, 0, 20, 1, 0 },
+		{ "5VSB",		11, 0, 30, 1, 0 },
+		{ "CPU",		24, 1, 1, 1, 0 },
+		{ "System",		25, 1, 1, 1, 0 },
+		{ "PWM Phase1",		26, 1, 1, 1, 0 },
+		{ "PWM Phase2",		27, 1, 1, 1, 0 },
+		{ "PWM Phase3",		28, 1, 1, 1, 0 },
+		{ "PWM Phase4",		29, 1, 1, 1, 0 },
+		{ "PWM Phase5",		30, 1, 1, 1, 0 },
+		{ "CPU Fan",		32, 2, 60, 1, 0 },
+		{ "SYS Fan",		34, 2, 60, 1, 0 },
+		{ "AUX1 Fan",		33, 2, 60, 1, 0 },
+		{ "AUX2 Fan",		35, 2, 60, 1, 0 },
+		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
+		{ NULL, 0, 0, 0, 0, 0 } }
+	},
+	{ 0x001C, "unknown", {
+		{ "CPU Core",		 0, 0, 10, 1, 0 },
+		{ "DDR2",		 1, 0, 20, 1, 0 },
+		{ "DDR2 VTT",		 2, 0, 10, 1, 0 },
+		{ "CPU VTT",		 3, 0, 10, 1, 0 },
+		{ "MCH 1.25V",		 4, 0, 10, 1, 0 },
+		{ "ICHIO 1.5V",		 5, 0, 10, 1, 0 },
+		{ "ICH 1.05V",		 6, 0, 10, 1, 0 },
+		{ "ATX +12V (24-Pin)",	 7, 0, 60, 1, 0 },
+		{ "ATX +12V (8-pin)",	 8, 0, 60, 1, 0 },
+		{ "ATX +5V",		 9, 0, 30, 1, 0 },
+		{ "+3.3V",		10, 0, 20, 1, 0 },
+		{ "5VSB",		11, 0, 30, 1, 0 },
+		{ "CPU",		24, 1, 1, 1, 0 },
+		{ "System",		25, 1, 1, 1, 0 },
+		{ "PWM Phase1",		26, 1, 1, 1, 0 },
+		{ "PWM Phase2",		27, 1, 1, 1, 0 },
+		{ "PWM Phase3",		28, 1, 1, 1, 0 },
+		{ "PWM Phase4",		29, 1, 1, 1, 0 },
+		{ "PWM Phase5",		30, 1, 1, 1, 0 },
+		{ "CPU Fan",		32, 2, 60, 1, 0 },
+		{ "SYS Fan",		34, 2, 60, 1, 0 },
+		{ "AUX1 Fan",		33, 2, 60, 1, 0 },
+		{ "AUX2 Fan",		35, 2, 60, 1, 0 },
+		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
+		{ NULL, 0, 0, 0, 0, 0 } }
+	},
 	{ 0x0000, NULL, { { NULL, 0, 0, 0, 0, 0 } } }
 };
 

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch

[Hans de Goede]

Jean Delvare wrote:
> Out of curiosity, what's the plan to get the actual board names instead
> of "unknown"? Shouldn't you ask people to report (e.g. in
> Documentation/hwmon/abituguru3) when their board is listed as unknown?
> 

People reporting the board names is the base idea yes. Adding something to the 
doc about this is a good idea, I'll write a patch for this.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards-v2.patch

[Jean Delvare]

On Sun, 21 Oct 2007 00:55:35 +0200, Hans de Goede wrote:
> Hi All,
> 
> This patch adds support for 2 new motherboards to the abituguru3 driver. This
> time with list terminators and closing brackets, sorry about the bad previous
> patch.
> 
> Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards-v2.patch

[Mark M. Hoffman]

Hi:

* Jean Delvare <khali@linux-fr.org> [2007-10-21 20:36:17 +0200]:
> On Sun, 21 Oct 2007 00:55:35 +0200, Hans de Goede wrote:
> > Hi All,
> > 
> > This patch adds support for 2 new motherboards to the abituguru3 driver. This
> > time with list terminators and closing brackets, sorry about the bad previous
> > patch.
> > 
> > Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors