[PATCH] TODO

[PATCH] TODO

[Robert Millan]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]


It seems the TODO is horribly outdated, so I gave it a review.  I think these
are already fixed.  Is it correct?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

[-- Attachment #2: todo.diff --]
[-- Type: text/x-diff, Size: 957 bytes --]

--- grub2/TODO	2005-01-04 15:01:44.000000000 +0100
+++ TODO	2007-10-19 23:01:15.000000000 +0200
@@ -13,7 +13,7 @@
   higher priority.
 
 
-* Add more filesystems (such as jfs, xfs and reiserfs). !
+* Add more filesystems (such as jfs and reiserfs). !
 
 * Add journal playback support to ext2fs (so it will become ext3fs).
 
@@ -21,23 +21,12 @@
 
 * Add more loaders (such as NetBSD and FreeBSD). !!
 
-* Implement a more friendly installer.
-
-* Add more terminals (such as serial). !
-
-* Implement a normal mode. !!!
+* Add more terminals. !
 
 * Write a manual.
 
-* Add support for compressed files.
-
 * Add support for network devices.
 
-* Fix the graphics mode completely and improve it to support VESA
-  as well as VGA modes. !
-
 * Add a fancy menu interface which utilizes the graphics mode
   extensively with many eye-candies. This is important to beat
   GRUB legacy. :)
-
-* Audit util/powerpc/ieee1275/grub-mkimage.c for endianness fixes.

Re: [PATCH] TODO

[Marco Gerards]

Robert Millan <rmh@aybabtu.com> writes:

> It seems the TODO is horribly outdated, so I gave it a review.  I think these
> are already fixed.  Is it correct?

You are right, this file is outdated.  Many things have been
implemented already.  Now we use the TODO on the wiki, which is also
outdated.

--
Marco

Re: [PATCH] TODO

[Robert Millan]

On Sun, Oct 21, 2007 at 12:24:36PM +0200, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
> 
> > It seems the TODO is horribly outdated, so I gave it a review.  I think these
> > are already fixed.  Is it correct?
> 
> You are right, this file is outdated.  Many things have been
> implemented already.  Now we use the TODO on the wiki, which is also
> outdated.

Should the TODO in CVS be updated with my patch, or removed altogether?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: [PATCH] TODO

[Vesa Jääskeläinen]

Robert Millan wrote:
> On Sun, Oct 21, 2007 at 12:24:36PM +0200, Marco Gerards wrote:
>> Robert Millan <rmh@aybabtu.com> writes:
>>
>>> It seems the TODO is horribly outdated, so I gave it a review.  I think these
>>> are already fixed.  Is it correct?
>> You are right, this file is outdated.  Many things have been
>> implemented already.  Now we use the TODO on the wiki, which is also
>> outdated.
> 
> Should the TODO in CVS be updated with my patch, or removed altogether?
> 

Perhaps add reference to Wiki page. And update Wiki ;)

Re: [PATCH] TODO

[Jordi Mallach]

On Sun, Oct 21, 2007 at 03:40:03PM +0300, Vesa Jääskeläinen wrote:
> > Should the TODO in CVS be updated with my patch, or removed altogether?
> Perhaps add reference to Wiki page. And update Wiki ;)

That makes you have a network connection to have a look at it. I
personally would like to be able to find it in the source.

-- 
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
jordi@sindominio.net     jordi@debian.org     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/

Re: [PATCH] TODO

[Vesa Jääskeläinen]

Jordi Mallach wrote:
> On Sun, Oct 21, 2007 at 03:40:03PM +0300, Vesa Jääskeläinen wrote:
>>> Should the TODO in CVS be updated with my patch, or removed altogether?
>> Perhaps add reference to Wiki page. And update Wiki ;)
> 
> That makes you have a network connection to have a look at it. I
> personally would like to be able to find it in the source.

Current grub 2 development information is based on Wiki at the moment,
please download notes from there. Once central place for the information
is essential so there is even a chance that it is up-to-date.

Re: [PATCH] TODO

[Robert Millan]

On Sun, Oct 21, 2007 at 03:21:26PM +0200, Jordi Mallach wrote:
> On Sun, Oct 21, 2007 at 03:40:03PM +0300, Vesa Jääskeläinen wrote:
> > > Should the TODO in CVS be updated with my patch, or removed altogether?
> > Perhaps add reference to Wiki page. And update Wiki ;)
> 
> That makes you have a network connection to have a look at it. I
> personally would like to be able to find it in the source.

But you also need a network connection to get the source.  How is that
different from the wiki?  (you can retrieve offline copies of the wiki,
too ;-))

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: [PATCH] TODO

[Robert Millan]

What do we do about this?   Keep updating the TODO file or get rif of it?

On Fri, Oct 19, 2007 at 11:02:22PM +0200, Robert Millan wrote:
> 
> It seems the TODO is horribly outdated, so I gave it a review.  I think these
> are already fixed.  Is it correct?
> 
> -- 
> Robert Millan
> 
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What use is a phone call, if you are unable to speak?
> (as seen on /.)

> --- grub2/TODO	2005-01-04 15:01:44.000000000 +0100
> +++ TODO	2007-10-19 23:01:15.000000000 +0200
> @@ -13,7 +13,7 @@
>    higher priority.
>  
>  
> -* Add more filesystems (such as jfs, xfs and reiserfs). !
> +* Add more filesystems (such as jfs and reiserfs). !
>  
>  * Add journal playback support to ext2fs (so it will become ext3fs).
>  
> @@ -21,23 +21,12 @@
>  
>  * Add more loaders (such as NetBSD and FreeBSD). !!
>  
> -* Implement a more friendly installer.
> -
> -* Add more terminals (such as serial). !
> -
> -* Implement a normal mode. !!!
> +* Add more terminals. !
>  
>  * Write a manual.
>  
> -* Add support for compressed files.
> -
>  * Add support for network devices.
>  
> -* Fix the graphics mode completely and improve it to support VESA
> -  as well as VGA modes. !
> -
>  * Add a fancy menu interface which utilizes the graphics mode
>    extensively with many eye-candies. This is important to beat
>    GRUB legacy. :)
> -
> -* Audit util/powerpc/ieee1275/grub-mkimage.c for endianness fixes.

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: [PATCH] TODO

[Yoshinori K. Okuji]

On Sunday 30 December 2007 16:14, Robert Millan wrote:
> What do we do about this?   Keep updating the TODO file or get rif of it?

Personally, I think it is easier to just point to another place, such 
as "Please look at this URL.", using the wiki (or an issue tracker, if you 
prefer).

Thanks,
Okuji

Re: [PATCH] TODO

[Robert Millan]

On Sun, Dec 30, 2007 at 05:16:41PM +0100, Yoshinori K. Okuji wrote:
> On Sunday 30 December 2007 16:14, Robert Millan wrote:
> > What do we do about this?   Keep updating the TODO file or get rif of it?
> 
> Personally, I think it is easier to just point to another place, such 
> as "Please look at this URL.", using the wiki (or an issue tracker, if you 
> prefer).

Ok, I propose replacing it with:

<cut here>
Before working on improving GRUB, it's very important that you
make contact with the core GRUB developers. Things herein might be
slightly out of date or otherwise not easy to understand at first
glance. So write to <grub-devel@gnu.org> first.

For bug tracking, refer to:

  http://savannah.gnu.org/bugs/?group=grub

Our wiki also lists some areas that need work:

  http://grub.enbug.org/
</cut here>

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Re: [PATCH] TODO

[Marco Gerards]

Robert Millan <rmh@aybabtu.com> writes:

> On Sun, Dec 30, 2007 at 05:16:41PM +0100, Yoshinori K. Okuji wrote:
>> On Sunday 30 December 2007 16:14, Robert Millan wrote:
>> > What do we do about this?   Keep updating the TODO file or get rif of it?
>> 
>> Personally, I think it is easier to just point to another place, such 
>> as "Please look at this URL.", using the wiki (or an issue tracker, if you 
>> prefer).
>
> Ok, I propose replacing it with:
>
> <cut here>
> Before working on improving GRUB, it's very important that you
> make contact with the core GRUB developers. Things herein might be
> slightly out of date or otherwise not easy to understand at first
> glance. So write to <grub-devel@gnu.org> first.
>
> For bug tracking, refer to:
>
>   http://savannah.gnu.org/bugs/?group=grub
>
> Our wiki also lists some areas that need work:
>
>   http://grub.enbug.org/
> </cut here>

This sounds like a good idea to me.

--
Marco

Re: [PATCH] TODO

[Robert Millan]

On Mon, Jan 07, 2008 at 07:52:12PM +0100, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
> 
> > On Sun, Dec 30, 2007 at 05:16:41PM +0100, Yoshinori K. Okuji wrote:
> >> On Sunday 30 December 2007 16:14, Robert Millan wrote:
> >> > What do we do about this?   Keep updating the TODO file or get rif of it?
> >> 
> >> Personally, I think it is easier to just point to another place, such 
> >> as "Please look at this URL.", using the wiki (or an issue tracker, if you 
> >> prefer).
> >
> > Ok, I propose replacing it with:
> >
> > <cut here>
> > Before working on improving GRUB, it's very important that you
> > make contact with the core GRUB developers. Things herein might be
> > slightly out of date or otherwise not easy to understand at first
> > glance. So write to <grub-devel@gnu.org> first.
> >
> > For bug tracking, refer to:
> >
> >   http://savannah.gnu.org/bugs/?group=grub
> >
> > Our wiki also lists some areas that need work:
> >
> >   http://grub.enbug.org/
> > </cut here>
> 
> This sounds like a good idea to me.

Committed then!

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)