Re: [PATCH 1/3] iptables-edit: iptables-edit: adds --table to iptables-restore

[Peter Warasin <peter@endian.com>]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Hi Jan

Jan Engelhardt wrote:
> Well, please send patches inline so I can reply to something.

Ok,..  I think i eventually have to upgrade my thunderbird, since i have
no option for sending inline attachments :-O


> |adds --table to iptables-restore which allows to restore only the
> |supplied table

This patch is already applied. Should i fix your suggestions or leave it
as it is?



> |-	while ((c = getopt_long(argc, argv, "bcvthnM:", options, NULL)) != -1) {
> |+	while ((c = getopt_long(argc, argv, "bcvthnM:T:", options, NULL)) != -1) {
> 
> Use -t instead, that would go in line with the -t from iptables.

-t is already --test, therefore i used -T
I suggest changing --test to --dry-run (-d), so -t will turn free for
--table, what do you think?

peter

-- 
:: e n d i a n
:: open source - open minds

:: peter warasin
:: http://www.endian.com   :: peter@endian.com

[-- Attachment #2: peter.vcf --]
[-- Type: text/x-vcard, Size: 279 bytes --]

begin:vcard
fn:Peter Warasin
n:;Peter Warasin
org:Endian GmbH/Srl
adr:;;Pillhof 47;Frangart/Frangarto;BZ;I-39010;Italien/Italia
email;internet:peter@endian.com
tel;work:+39 0471 631763
tel;fax:+39 0471 631764
x-mozilla-html:FALSE
url:http://www.endian.com
version:2.1
end:vcard