All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Warasin <peter@endian.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] iptables-edit: iptables-edit: adds --table to iptables-restore
Date: Wed, 07 Nov 2007 20:50:01 +0100	[thread overview]
Message-ID: <473216E9.1040309@endian.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711072026550.20249@fbirervta.pbzchgretzou.qr>

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi Jan

Jan Engelhardt wrote:
> On Nov 7 2007 20:11, Peter Warasin wrote:
>> If you want me to change it to --dry-run, i will do that, so i can use
>> -t for --table.
> 
> be prepared to hear the 'that breaks compatibilty' argument.
> Though, since it's 1.4.0, I'd go for it :p

I imagine :)
Ok, i will try.

BTW: Is somewhere some sort of coding style documentation which i can
read in order to prevent such mistakes, or is it just the linux kernel
coding style?

Some of the malformed style you suggested to change are due to
copy&paste of current iptables code, which i used as reference in some
cases, so i am little confused now.

peter

-- 
:: e n d i a n
:: open source - open minds

:: peter warasin
:: http://www.endian.com   :: peter@endian.com

[-- Attachment #2: peter.vcf --]
[-- Type: text/x-vcard, Size: 279 bytes --]

begin:vcard
fn:Peter Warasin
n:;Peter Warasin
org:Endian GmbH/Srl
adr:;;Pillhof 47;Frangart/Frangarto;BZ;I-39010;Italien/Italia
email;internet:peter@endian.com
tel;work:+39 0471 631763
tel;fax:+39 0471 631764
x-mozilla-html:FALSE
url:http://www.endian.com
version:2.1
end:vcard


  reply	other threads:[~2007-11-07 19:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05  0:13 [PATCH 1/3] iptables-edit: iptables-edit: adds --table to iptables-restore Peter Warasin
2007-11-06  0:12 ` Patrick McHardy
2007-11-07 10:52 ` Jan Engelhardt
2007-11-07 13:44   ` Peter Warasin
2007-11-07 16:41     ` Jan Engelhardt
2007-11-07 18:15       ` Peter Warasin
2007-11-07 18:34         ` Jan Engelhardt
2007-11-07 19:11           ` Peter Warasin
2007-11-07 19:27             ` Jan Engelhardt
2007-11-07 19:50               ` Peter Warasin [this message]
2007-11-07 20:42                 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473216E9.1040309@endian.com \
    --to=peter@endian.com \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.