Re: [PATCH 1/3] iptables-edit: iptables-edit: adds --table to iptables-restore

[Peter Warasin <peter@endian.com>]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Hi Jan

Jan Engelhardt wrote:
> On Nov 7 2007 19:15, Peter Warasin wrote:
>>> Is a dry-run option really needed? iptables-edit does not commit
>> Attention, this is a new option of iptables-restore, not of iptables-edit.

> -t means table for:
[..]
> iptables-restore having -t for test really seems out of place.

i agree.


> That said, iptables-restore does not have a -t, according to its help text
> ("iptables-restore -h") and its manpage.

Thats not true. The current subversion code uses -t for --test. Probably
you confuse with iptables-save ?

http://svn.netfilter.org/cgi-bin/viewcvs.cgi/trunk/iptables/iptables-restore.c?rev=7087&view=markup
-------- snip -----------------------------------------------
			case 't':
				testing = 1;
				break;
-------- snap -----------------------------------------------

If you want me to change it to --dry-run, i will do that, so i can use
-t for --table.

peter

-- 
:: e n d i a n
:: open source - open minds

:: peter warasin
:: http://www.endian.com   :: peter@endian.com

[-- Attachment #2: peter.vcf --]
[-- Type: text/x-vcard, Size: 279 bytes --]

begin:vcard
fn:Peter Warasin
n:;Peter Warasin
org:Endian GmbH/Srl
adr:;;Pillhof 47;Frangart/Frangarto;BZ;I-39010;Italien/Italia
email;internet:peter@endian.com
tel;work:+39 0471 631763
tel;fax:+39 0471 631764
x-mozilla-html:FALSE
url:http://www.endian.com
version:2.1
end:vcard