[lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Hans de Goede]

Hi All,

A patch for compiling sensors-applet against lm_sensors-3.0.0 is now available 
from: http://www.lm-sensors.org/wiki/Download

Note that this patch also adds support to the lm_sensors-2.x code for reading 
the low and high (sensors-applet speak for min and max) values from libsensors 
instead of using hardcoded defaults depending on the sensor type.

This is thrown into the mix as the lm_sensors-3x support patch is incremental 
to the min/max reading patch for the 2.x code.

Both patches have been send upstream.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Jean Delvare]

Hi Hans,

On Mon, 12 Nov 2007 22:14:47 +0100, Hans de Goede wrote:
> A patch for compiling sensors-applet against lm_sensors-3.0.0 is now available 
> from: http://www.lm-sensors.org/wiki/Download
> 
> Note that this patch also adds support to the lm_sensors-2.x code for reading 
> the low and high (sensors-applet speak for min and max) values from libsensors 
> instead of using hardcoded defaults depending on the sensor type.
> 
> This is thrown into the mix as the lm_sensors-3x support patch is incremental 
> to the min/max reading patch for the 2.x code.
> 
> Both patches have been send upstream.

Great, thanks for doing this!

So, are you done with your porting work? If so, and if you didn't find
any problem with the new libsensors API, is there any reason to delay
the release of lm-sensors 3.0.0 any further?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Hans de Goede]

Jean Delvare wrote:
> Hi Hans,
> 
> On Mon, 12 Nov 2007 22:14:47 +0100, Hans de Goede wrote:
>> A patch for compiling sensors-applet against lm_sensors-3.0.0 is now available 
>> from: http://www.lm-sensors.org/wiki/Download
>>
>> Note that this patch also adds support to the lm_sensors-2.x code for reading 
>> the low and high (sensors-applet speak for min and max) values from libsensors 
>> instead of using hardcoded defaults depending on the sensor type.
>>
>> This is thrown into the mix as the lm_sensors-3x support patch is incremental 
>> to the min/max reading patch for the 2.x code.
>>
>> Both patches have been send upstream.
> 
> Great, thanks for doing this!
> 
> So, are you done with your porting work? If so, and if you didn't find
> any problem with the new libsensors API, is there any reason to delay
> the release of lm-sensors 3.0.0 any further?

I'm not done with my porting work, next on the list is net-snmp, which looks 
easy to fix, I'll take a shot at it tomorrow. Then we also have an xfce applet 
and kdelibs (although that might only depend on lm_sensors through net-snmp).

However judging from my experience sofar the API is fine, so I see no reason to 
delay 3.0.0

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Jean Delvare]

Hi Hans,

On Tue, 13 Nov 2007 22:08:48 +0100, Hans de Goede wrote:
> Jean Delvare wrote:
> > So, are you done with your porting work? If so, and if you didn't find
> > any problem with the new libsensors API, is there any reason to delay
> > the release of lm-sensors 3.0.0 any further?
> 
> I'm not done with my porting work, next on the list is net-snmp, which looks 
> easy to fix, I'll take a shot at it tomorrow. Then we also have an xfce applet 

I am interested in net-snmp as well, so maybe we can work on this
together. Well, you'll certainly be quicker than me on the code, but I
can review your patch and push it in opensuse.

> and kdelibs (although that might only depend on lm_sensors through net-snmp).

On my end (opensuse), I have kdegraphics and kdeutils which depend on
net-snmp. Only kdebase depends on libsensors directly (for ksysguard.)

> However judging from my experience sofar the API is fine, so I see no reason to 
> delay 3.0.0

Excellent. I'll do the release as my time permits. I'm very busy this
week though, so it might not be until next week.

P.S.: Please remember to add a short comment to your wiki edits so that
others see what's happening.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Hans de Goede]

Jean Delvare wrote:
> Hi Hans,
> 
> On Tue, 13 Nov 2007 22:08:48 +0100, Hans de Goede wrote:
>> Jean Delvare wrote:
>>> So, are you done with your porting work? If so, and if you didn't find
>>> any problem with the new libsensors API, is there any reason to delay
>>> the release of lm-sensors 3.0.0 any further?
>> I'm not done with my porting work, next on the list is net-snmp, which looks 
>> easy to fix, I'll take a shot at it tomorrow. Then we also have an xfce applet 
> 
> I am interested in net-snmp as well, so maybe we can work on this
> together. Well, you'll certainly be quicker than me on the code, but I
> can review your patch and push it in opensuse.
> 

Hmm,

While coordinating my work with the Fedora net-snmp maintainer I got attended 
that upstream us already working on this:
http://sourceforge.net/mailarchive/message.php?msg_name®77C0A0A0DC9B49BAA800A119E82EA207CD5D83%40EDM-GOA-EXCC-1A.goa.ds.gov.ab.ca

However the upstream work is a complete rewrite of the sensors code in 
net-snmp, as I have no idea when that will be stable and I don't want to 
completely break the development branch of Fedora (quite a few things require 
net-snmp) I'll also be writing a patch against the current stable net-snmp 
release, I already took a look and the code is quite isolated, fixing this for 
the current stable net-snmp release should be quite easy.

>> and kdelibs (although that might only depend on lm_sensors through net-snmp).
> 
> On my end (opensuse), I have kdegraphics and kdeutils which depend on
> net-snmp. Only kdebase depends on libsensors directly (for ksysguard.)
> 

My bad I meant kdebase.


> P.S.: Please remember to add a short comment to your wiki edits so that
> others see what's happening.
> 

Will do in the future.

Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Hans de Goede]

Hans de Goede wrote:
> Jean Delvare wrote:
>> Hi Hans,
>>
>> On Tue, 13 Nov 2007 22:08:48 +0100, Hans de Goede wrote:
>>> Jean Delvare wrote:
>>>> So, are you done with your porting work? If so, and if you didn't find
>>>> any problem with the new libsensors API, is there any reason to delay
>>>> the release of lm-sensors 3.0.0 any further?
>>> I'm not done with my porting work, next on the list is net-snmp, 
>>> which looks easy to fix, I'll take a shot at it tomorrow. Then we 
>>> also have an xfce applet 
>>
>> I am interested in net-snmp as well, so maybe we can work on this
>> together. Well, you'll certainly be quicker than me on the code, but I
>> can review your patch and push it in opensuse.
>>
> 
> Hmm,
> 
> While coordinating my work with the Fedora net-snmp maintainer I got 
> attended that upstream us already working on this:
> http://sourceforge.net/mailarchive/message.php?msg_name®77C0A0A0DC9B49BAA800A119E82EA207CD5D83%40EDM-GOA-EXCC-1A.goa.ds.gov.ab.ca 
> 
> 
> However the upstream work is a complete rewrite of the sensors code in 
> net-snmp, as I have no idea when that will be stable and I don't want to 
> completely break the development branch of Fedora (quite a few things 
> require net-snmp) I'll also be writing a patch against the current 
> stable net-snmp release, I already took a look and the code is quite 
> isolated, fixing this for the current stable net-snmp release should be 
> quite easy.
> 

Ok,

Scrap that, upstream has finished lm_sensors-3.x support and the Fedora 
net-snmp maintainer has decided to backport the sensors infra changes + 
lm_sensors-3.x.x support to the current stable net-snmp, patch available here:
http://cvs.fedoraproject.org/viewcvs/devel/net-snmp/net-snmp-5.4.1-sensors3.patch?rev=1.1

Shall I add this to the wiki? Its a bit intrusive.

Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] lm-sensors-3.0.0 patch for (gnome) sensors-applet

[Jean Delvare]

Hi Hans,

On Thu, 15 Nov 2007 10:52:01 +0100, Hans de Goede wrote:
> Hans de Goede wrote:
> > While coordinating my work with the Fedora net-snmp maintainer I got 
> > attended that upstream us already working on this:
> > http://sourceforge.net/mailarchive/message.php?msg_name®77C0A0A0DC9B49BAA800A119E82EA207CD5D83%40EDM-GOA-EXCC-1A.goa.ds.gov.ab.ca 
> > 
> > 
> > However the upstream work is a complete rewrite of the sensors code in 
> > net-snmp, as I have no idea when that will be stable and I don't want to 
> > completely break the development branch of Fedora (quite a few things 
> > require net-snmp) I'll also be writing a patch against the current 
> > stable net-snmp release, I already took a look and the code is quite 
> > isolated, fixing this for the current stable net-snmp release should be 
> > quite easy.
> 
> Scrap that, upstream has finished lm_sensors-3.x support and the Fedora 
> net-snmp maintainer has decided to backport the sensors infra changes + 
> lm_sensors-3.x.x support to the current stable net-snmp, patch available here:
> http://cvs.fedoraproject.org/viewcvs/devel/net-snmp/net-snmp-5.4.1-sensors3.patch?rev=1.1

This is excellent news. One less project for us to take care of :)

> Shall I add this to the wiki? Its a bit intrusive.

You can always add a link to the patch for interested people. Then
every distribution will decide whether to apply it or not.

A less intrusive patch for net-snmp stable would also be nice to have,
but only if someone actually has the time to work on that (I don't.)

Thanks and congrats to the net-snmp and Fedora folks involved!

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors