[patch 1/1][NETNS] fix fib_frontend compilation error

[patch 1/1][NETNS] fix fib_frontend compilation error

[dlezcano-NmTC/0ZBporQT0dZR+AlfA]

[-- Attachment #1: fix-fib-frontend-compilation.patch --]
[-- Type: text/plain, Size: 843 bytes --]

Added net namespace parameter to fib4_rules_init when statically
defined in fib_frontend.c

Signed-off-by: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
---
 net/ipv4/fib_frontend.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-netns/net/ipv4/fib_frontend.c
===================================================================
--- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
+++ linux-2.6-netns/net/ipv4/fib_frontend.c
@@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
 #define FIB_TABLE_HASHSZ 1
 static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
 
-static void __init fib4_rules_init(void)
+static void __init fib4_rules_init(struct net *net)
 {
 	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
 	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);

-- 

Re: [patch 1/1][NETNS] fix fib_frontend compilation error

[Denis V. Lunev]

applied... though I am not too familiar with git and the author has been
set to me rather than you with your signed-off :(

Sorry,
	Den

dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org wrote:
> Added net namespace parameter to fib4_rules_init when statically
> defined in fib_frontend.c
> 
> Signed-off-by: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
> ---
>  net/ipv4/fib_frontend.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6-netns/net/ipv4/fib_frontend.c
> ===================================================================
> --- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
> +++ linux-2.6-netns/net/ipv4/fib_frontend.c
> @@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
>  #define FIB_TABLE_HASHSZ 1
>  static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
>  
> -static void __init fib4_rules_init(void)
> +static void __init fib4_rules_init(struct net *net)
>  {
>  	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
>  	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);
> 

Re: [patch 1/1][NETNS] fix fib_frontend compilation error

[Daniel Lezcano]

Denis V. Lunev wrote:
> applied... though I am not too familiar with git and the author has been
> set to me rather than you with your signed-off :(

It's ok :)

I think you should specify the --author option when commiting.

By the way, I see that there are some patches without your Signed-off 
and you are in the delivery path, shouldn't you Signed-off all the patches ?

Re: [patch 1/1][NETNS] fix fib_frontend compilation error

[Eric W. Biederman]

Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org> writes:

> Denis V. Lunev wrote:
>> applied... though I am not too familiar with git and the author has been
>> set to me rather than you with your signed-off :(
>
> It's ok :)
>
> I think you should specify the --author option when commiting.

My normal technique here is to simply save the entire email message
and then do git-am email.txt and git picks it all up from the
headers.

Eric

Re: [patch 1/1][NETNS] fix fib_frontend compilation error

[Denis V. Lunev]

apparently, the patch is not enough, fib4_rules_init is called from
non-init function. I'll drop this one during port to 2.6.25 tree

dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org wrote:
> Added net namespace parameter to fib4_rules_init when statically
> defined in fib_frontend.c
> 
> Signed-off-by: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
> ---
>  net/ipv4/fib_frontend.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6-netns/net/ipv4/fib_frontend.c
> ===================================================================
> --- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
> +++ linux-2.6-netns/net/ipv4/fib_frontend.c
> @@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
>  #define FIB_TABLE_HASHSZ 1
>  static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
>  
> -static void __init fib4_rules_init(void)
> +static void __init fib4_rules_init(struct net *net)
>  {
>  	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
>  	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);
>