From: Jeremy Fitzhardinge <jeremy@goop.org>
To: 7eggert@gmx.de
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen: relax signature check
Date: Tue, 11 Dec 2007 09:16:21 -0800 [thread overview]
Message-ID: <475EC5E5.80104@goop.org> (raw)
In-Reply-To: <E1J27Or-00012X-DF@be1.7eggert.dyndns.org>
Bodo Eggert wrote:
> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ?
> I don't thin Xen version 32 will be compatible ...
>
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
But this is just a sanity check to make sure things are basically OK;
BUG_ON is hardly nice error reporting (not that there's much else we can
do at that point).
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: 7eggert@gmx.de
Cc: Andrew Morton <akpm@linux-foundation.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: relax signature check
Date: Tue, 11 Dec 2007 09:16:21 -0800 [thread overview]
Message-ID: <475EC5E5.80104@goop.org> (raw)
In-Reply-To: <E1J27Or-00012X-DF@be1.7eggert.dyndns.org>
Bodo Eggert wrote:
> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ?
> I don't thin Xen version 32 will be compatible ...
>
It had better be; if it loads the kernel, it should present a xen-3
compatible ABI.
But this is just a sanity check to make sure things are basically OK;
BUG_ON is hardly nice error reporting (not that there's much else we can
do at that point).
J
next prev parent reply other threads:[~2007-12-11 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9yY38-5oa-11@gated-at.bofh.it>
2007-12-11 15:52 ` [PATCH] xen: relax signature check Bodo Eggert
2007-12-11 15:52 ` Bodo Eggert
2007-12-11 17:16 ` Jeremy Fitzhardinge [this message]
2007-12-11 17:16 ` Jeremy Fitzhardinge
2007-12-12 19:14 ` Anthony Liguori
2007-12-12 19:14 ` Anthony Liguori
2007-12-12 19:36 ` Jeremy Fitzhardinge
2007-12-12 19:36 ` Jeremy Fitzhardinge
2007-12-10 21:00 Jeremy Fitzhardinge
2007-12-10 21:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475EC5E5.80104@goop.org \
--to=jeremy@goop.org \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.