From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: 7eggert@gmx.de, Andrew Morton <akpm@linux-foundation.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: relax signature check
Date: Wed, 12 Dec 2007 11:36:28 -0800 [thread overview]
Message-ID: <4760383C.2040502@goop.org> (raw)
In-Reply-To: <47603332.8060605@codemonkey.ws>
Anthony Liguori wrote:
> If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible
> too? I think the point was that you should either be checking for
> 'xen-3.x' or something more general that would accept anything >=
> xen-3.0.
The signature is supposed to be an ABI signature, so regardless of the
actual hypervisor version, it should always present "xen-3.0"
(presumably backwards compat if it also supports other versions of the
ABI). There was a bug in some versions where it puts the actual
hypervisor version in there, requiring this patch. Technically that
means that looking for "xen-3." is more accurate, but frankly not
important enough to bother raising a patch over.
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: 7eggert@gmx.de, Xen-devel <xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: relax signature check
Date: Wed, 12 Dec 2007 11:36:28 -0800 [thread overview]
Message-ID: <4760383C.2040502@goop.org> (raw)
In-Reply-To: <47603332.8060605@codemonkey.ws>
Anthony Liguori wrote:
> If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible
> too? I think the point was that you should either be checking for
> 'xen-3.x' or something more general that would accept anything >=
> xen-3.0.
The signature is supposed to be an ABI signature, so regardless of the
actual hypervisor version, it should always present "xen-3.0"
(presumably backwards compat if it also supports other versions of the
ABI). There was a bug in some versions where it puts the actual
hypervisor version in there, requiring this patch. Technically that
means that looking for "xen-3." is more accurate, but frankly not
important enough to bother raising a patch over.
J
next prev parent reply other threads:[~2007-12-12 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9yY38-5oa-11@gated-at.bofh.it>
2007-12-11 15:52 ` [PATCH] xen: relax signature check Bodo Eggert
2007-12-11 17:16 ` Jeremy Fitzhardinge
2007-12-11 17:16 ` Jeremy Fitzhardinge
2007-12-12 19:14 ` Anthony Liguori
2007-12-12 19:14 ` Anthony Liguori
2007-12-12 19:36 ` Jeremy Fitzhardinge [this message]
2007-12-12 19:36 ` Jeremy Fitzhardinge
2007-12-11 15:52 ` Bodo Eggert
2007-12-10 21:00 Jeremy Fitzhardinge
2007-12-10 21:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4760383C.2040502@goop.org \
--to=jeremy@goop.org \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.