Re: [PATCH 6/27] xt_CONNMARK target, revision 1

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> commit ff3ddea4afa7f7b7735ae439bb1cd82e5413d99e
> Author: Jan Engelhardt <jengelh@computergmbh.de>
> Date:   Wed Jan 2 17:42:13 2008 +0100
> 
>     [NETFILTER]: xt_CONNMARK target, revision 1
>     
>     Introduces the xt_CONNMARK target revision 1. It uses fixed types, and
>     also uses the more expressive XOR logic. Futhermore, it allows to
>     selectively pick bits from both the ctmark and the nfmark in the SAVE
>     and RESTORE operations.

Applied with some minor cosmetic changes:

> +static unsigned int
> +connmark_tg(struct sk_buff *skb, const struct net_device *in,
> +            const struct net_device *out, unsigned int hooknum,
> +            const struct xt_target *target, const void *targinfo)
> +{
> +	const struct xt_connmark_tginfo1 *info = targinfo;
> +	enum ip_conntrack_info ctinfo;
> +	struct nf_conn *ct;
> +	u_int32_t newmark;
> +
> +	ct = nf_ct_get(skb, &ctinfo);
> +	if (ct == NULL)
> +		return XT_CONTINUE;
> +
> +	switch (info->mode) {
> +		case XT_CONNMARK_SET:

switch cases should not be indented deeper then the switch statement.