Re: [PATCH 8/27] xt_connmark match, revision 1

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> On Jan 4 2008 15:56, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> commit 375972a6ff3579f150bf916621b6fe752d29f25a
>>> Author: Jan Engelhardt <jengelh@computergmbh.de>
>>> Date:   Wed Jan 2 17:52:04 2008 +0100
>>>
>>>     [NETFILTER]: xt_connmark match, revision 1
>>>     
>>>   {
>>> 		.name		= "connmark",
>>> +		.revision	= 0,
>>> 		.family		= AF_INET6,
>>> -		.checkentry	= connmark_mt_check,
>>> -		.match		= connmark_mt,
>>> +		.checkentry	= connmark_mt_check_v0,
>>> +		.match		= connmark_mt_v0,
>>>    .destroy	= connmark_mt_destroy,
>>>    .matchsize	= sizeof(struct xt_connmark_info),
>>>  #ifdef CONFIG_COMPAT
>> This did not compile BTW because you forgot to update the compat
>> functions for IPv6. Please always test compilation for all affected
>> cases, if you don't have a machine which needs the compat code,
>> simply defining CONFIG_COMPAT yourself should work.
>>
> 
> Have you fixed it during cherrypick? (If so, thanks!)

Yes, I fixed it.

> Well at least I tested CONFIG_IPV6=n ;-)

Thats at least as important since this is what regulary made
compilation fail for Linus :)