From: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
Glauber de Oliveira Costa
<gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/3] kvmclock - the host part.
Date: Wed, 16 Jan 2008 09:54:58 +0100 [thread overview]
Message-ID: <478DC662.6010902@redhat.com> (raw)
In-Reply-To: <478DC2CF.4040803-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Hi,
> We want to avoid updating wall clock all the time. As far as I
> understand, wall clock is just a base which doesn't change.
Yep, it is. Got that wrong first in xenner, with the result that guest
time ran at double speed ;)
>> +/* xen binary-compatible interfaces. See xen headers for details */
>> +struct xen_vcpu_time_info {
>> + uint32_t version;
>> + uint32_t pad0;
>> + uint64_t tsc_timestamp;
>> + uint64_t system_time;
>> + uint32_t tsc_to_system_mul;
>> + int8_t tsc_shift;
>> + int8_t pad1[3];
>> +};
>> +struct xen_vcpu_info {
>> + uint8_t pad[32];
>> + struct xen_vcpu_time_info time;
>> +};
>>
>
> Please drop xen_vcpu_info...
Oh, yeah. No point in assembling the whole xen shared info page. Just
xen_vcpu_time_info is enougth, it will work just fine for xenner.
cheers,
Gerd
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-16 8:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 15:10 [PATCH 0/3] kvm clock - with the patches this time Glauber de Oliveira Costa
[not found] ` <1200409817411-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 15:10 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Glauber de Oliveira Costa
[not found] ` <120040983179-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 15:10 ` [PATCH 2/3] kvmclock - the host part Glauber de Oliveira Costa
[not found] ` <12004098373625-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 15:10 ` [PATCH 3/3] [PATCH] kvmclock implementation, the guest part Glauber de Oliveira Costa
2008-01-16 8:39 ` [PATCH 2/3] kvmclock - the host part Avi Kivity
[not found] ` <478DC2CF.4040803-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-16 8:54 ` Gerd Hoffmann [this message]
[not found] ` <478DC662.6010902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16 9:32 ` Avi Kivity
2008-01-16 8:41 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2007-11-08 22:39 [PATCH 0/3] Kvm clocksource, new spin Glauber de Oliveira Costa
2007-11-08 22:39 ` [PATCH 1/3] include files for kvmclock Glauber de Oliveira Costa
2007-11-08 22:39 ` [PATCH 2/3] kvmclock - the host part Glauber de Oliveira Costa
2007-11-08 22:39 ` Glauber de Oliveira Costa
2007-11-11 10:17 ` Avi Kivity
2007-11-11 10:17 ` Avi Kivity
2007-11-13 11:28 ` Glauber de Oliveira Costa
2007-11-13 11:28 ` Glauber de Oliveira Costa
2007-11-13 14:44 ` Avi Kivity
2007-11-13 14:44 ` Avi Kivity
[not found] ` <11945615751747-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-13 5:00 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A025DF8A2-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-13 11:54 ` Glauber de Oliveira Costa
[not found] ` <4739906B.2080103-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-11-13 12:08 ` Izik Eidus
2007-11-13 14:47 ` Avi Kivity
[not found] ` <4739B916.4000405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-13 15:23 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A025DFB75-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-13 16:12 ` Avi Kivity
[not found] ` <4739CD03.90406-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-14 0:41 ` Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478DC662.6010902@redhat.com \
--to=kraxel-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jeremy-TSDbQ3PG+2Y@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.