Re: [PATCH 2/3] kvmclock - the host part.

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Gerd Hoffmann wrote:
>   Hi,
>
>   
>> We want to avoid updating wall clock all the time.  As far as I 
>> understand, wall clock is just a base which doesn't change.
>>     
>
> Yep, it is.  Got that wrong first in xenner, with the result that guest
> time ran at double speed ;)
>
>   
>>> +/* xen binary-compatible interfaces. See xen headers for details */
>>> +struct xen_vcpu_time_info {
>>> +	uint32_t version;
>>> +	uint32_t pad0;
>>> +	uint64_t tsc_timestamp;
>>> +	uint64_t system_time;
>>> +	uint32_t tsc_to_system_mul;
>>> +	int8_t   tsc_shift;
>>> +	int8_t   pad1[3];
>>> +};
>>>       
>
>   
>>> +struct xen_vcpu_info {
>>> +	uint8_t  pad[32];
>>> +	struct xen_vcpu_time_info time;
>>> +};
>>>   
>>>       
>> Please drop xen_vcpu_info...
>>     
>
> Oh, yeah.  No point in assembling the whole xen shared info page.  Just
> xen_vcpu_time_info is enougth, it will work just fine for xenner.
>
>   

We should also not use the xen_ namespace, that can only cause conflicts.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/