From: Avi Kivity <avi@qumranet.com>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, jeremy@goop.org,
aliguori@us.ibm.com, kvm-devel@lists.sourceforge.net,
hollisb@us.ibm.com
Subject: Re: [PATCH 2/3] kvmclock - the host part.
Date: Sun, 11 Nov 2007 12:17:36 +0200 [thread overview]
Message-ID: <4736D6C0.8040408@qumranet.com> (raw)
In-Reply-To: <11945615751747-git-send-email-gcosta@redhat.com>
Glauber de Oliveira Costa wrote:
> This is the host part of kvm clocksource implementation. As it does
> not include clockevents, it is a fairly simple implementation. We
> only have to register a per-vcpu area, and start writting to it periodically.
>
>
Missing live migration support (a way for userspace to read and write
the guest clock address). Should probably be in a separate patch.
> @@ -1924,6 +1955,7 @@ out:
> goto preempted;
> }
>
> + kvm_write_guest_time(vcpu);
> post_kvm_run_save(vcpu, kvm_run);
>
Why here? Seems like we're leaving the guest for a while at this place.
Suggest putting it on top of __vcpu_run(), guarded by a flag, and
setting the flag every time we put the vcpu.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Glauber de Oliveira Costa
<gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 2/3] kvmclock - the host part.
Date: Sun, 11 Nov 2007 12:17:36 +0200 [thread overview]
Message-ID: <4736D6C0.8040408@qumranet.com> (raw)
In-Reply-To: <11945615751747-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Glauber de Oliveira Costa wrote:
> This is the host part of kvm clocksource implementation. As it does
> not include clockevents, it is a fairly simple implementation. We
> only have to register a per-vcpu area, and start writting to it periodically.
>
>
Missing live migration support (a way for userspace to read and write
the guest clock address). Should probably be in a separate patch.
> @@ -1924,6 +1955,7 @@ out:
> goto preempted;
> }
>
> + kvm_write_guest_time(vcpu);
> post_kvm_run_save(vcpu, kvm_run);
>
Why here? Seems like we're leaving the guest for a while at this place.
Suggest putting it on top of __vcpu_run(), guarded by a flag, and
setting the flag every time we put the vcpu.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-11 10:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 22:39 [PATCH 0/3] Kvm clocksource, new spin Glauber de Oliveira Costa
2007-11-08 22:39 ` Glauber de Oliveira Costa
2007-11-08 22:39 ` [PATCH 1/3] include files for kvmclock Glauber de Oliveira Costa
2007-11-08 22:39 ` Glauber de Oliveira Costa
2007-11-08 22:39 ` [PATCH 2/3] kvmclock - the host part Glauber de Oliveira Costa
2007-11-08 22:39 ` Glauber de Oliveira Costa
2007-11-08 22:39 ` [PATCH 3/3] kvmclock implementation, the guest part Glauber de Oliveira Costa
2007-11-08 22:39 ` Glauber de Oliveira Costa
2007-11-11 10:17 ` Avi Kivity [this message]
2007-11-11 10:17 ` [PATCH 2/3] kvmclock - the host part Avi Kivity
2007-11-13 11:28 ` Glauber de Oliveira Costa
2007-11-13 11:28 ` Glauber de Oliveira Costa
2007-11-13 14:44 ` Avi Kivity
2007-11-13 14:44 ` Avi Kivity
2007-11-13 5:00 ` [kvm-devel] " Dong, Eddie
2007-11-13 5:00 ` Dong, Eddie
2007-11-13 11:54 ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-13 11:54 ` Glauber de Oliveira Costa
2007-11-13 12:08 ` [kvm-devel] " Izik Eidus
2007-11-13 12:08 ` Izik Eidus
2007-11-13 14:47 ` [kvm-devel] " Avi Kivity
2007-11-13 14:47 ` Avi Kivity
2007-11-13 15:23 ` [kvm-devel] " Dong, Eddie
2007-11-13 15:23 ` Dong, Eddie
2007-11-13 16:12 ` [kvm-devel] " Avi Kivity
2007-11-13 16:12 ` Avi Kivity
2007-11-14 0:41 ` [kvm-devel] " Dong, Eddie
2007-11-14 0:41 ` Dong, Eddie
2007-11-09 8:37 ` [PATCH 1/3] include files for kvmclock Gerd Hoffmann
2007-11-09 8:37 ` Gerd Hoffmann
2007-11-11 9:15 ` Avi Kivity
2007-11-11 9:15 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-01-15 15:10 [PATCH 0/3] kvm clock - with the patches this time Glauber de Oliveira Costa
2008-01-15 15:10 ` [PATCH 1/3] put kvm_para.h include outside __KERNEL__ Glauber de Oliveira Costa
[not found] ` <120040983179-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 15:10 ` [PATCH 2/3] kvmclock - the host part Glauber de Oliveira Costa
[not found] ` <12004098373625-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16 8:39 ` Avi Kivity
[not found] ` <478DC2CF.4040803-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-16 8:54 ` Gerd Hoffmann
[not found] ` <478DC662.6010902-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16 9:32 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4736D6C0.8040408@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=gcosta@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=jeremy@goop.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.