All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/6] powerpc: Use generic per cpu linux-2.6.git
Date: Wed, 30 Jan 2008 10:38:57 -0800	[thread overview]
Message-ID: <47A0C441.4020502@sgi.com> (raw)
In-Reply-To: <20080130182809.GA27168@elte.hu>

Ingo Molnar wrote:
> * travis@sgi.com <travis@sgi.com> wrote:
> 
>> Powerpc has a way to determine the address of the per cpu area of the 
>> currently executing processor via the paca and the array of per cpu 
>> offsets is avoided by looking up the per cpu area from the remote 
>> paca's (copying x86_64).
> 
> i needed the fix below to get my powerpc crosscompile build to succeed.
> 
> 	Ingo

Thanks!  I double-checked the logs and my ppc build worked.  But yes, this was
in the original patch.  And wierdly, powerpc was the only arch that had it
dropped.

-Mike
> 
> -------------->
> Subject: powerpc: percpu build fix
> From: Ingo Molnar <mingo@elte.hu>
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  include/asm-powerpc/percpu.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-x86.q/include/asm-powerpc/percpu.h
> ===================================================================
> --- linux-x86.q.orig/include/asm-powerpc/percpu.h
> +++ linux-x86.q/include/asm-powerpc/percpu.h
> @@ -13,7 +13,7 @@
>  #include <asm/paca.h>
>  
>  #define __per_cpu_offset(cpu) (paca[cpu].data_offset)
> -#define __my_cpu_offset() get_paca()->data_offset
> +#define __my_cpu_offset get_paca()->data_offset
>  #define per_cpu_offset(x) (__per_cpu_offset(x))
>  
>  #endif /* CONFIG_SMP */


WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/6] powerpc: Use generic per cpu linux-2.6.git
Date: Wed, 30 Jan 2008 10:38:57 -0800	[thread overview]
Message-ID: <47A0C441.4020502@sgi.com> (raw)
In-Reply-To: <20080130182809.GA27168@elte.hu>

Ingo Molnar wrote:
> * travis@sgi.com <travis@sgi.com> wrote:
> 
>> Powerpc has a way to determine the address of the per cpu area of the 
>> currently executing processor via the paca and the array of per cpu 
>> offsets is avoided by looking up the per cpu area from the remote 
>> paca's (copying x86_64).
> 
> i needed the fix below to get my powerpc crosscompile build to succeed.
> 
> 	Ingo

Thanks!  I double-checked the logs and my ppc build worked.  But yes, this was
in the original patch.  And wierdly, powerpc was the only arch that had it
dropped.

-Mike
> 
> -------------->
> Subject: powerpc: percpu build fix
> From: Ingo Molnar <mingo@elte.hu>
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  include/asm-powerpc/percpu.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-x86.q/include/asm-powerpc/percpu.h
> ===================================================================
> --- linux-x86.q.orig/include/asm-powerpc/percpu.h
> +++ linux-x86.q/include/asm-powerpc/percpu.h
> @@ -13,7 +13,7 @@
>  #include <asm/paca.h>
>  
>  #define __per_cpu_offset(cpu) (paca[cpu].data_offset)
> -#define __my_cpu_offset() get_paca()->data_offset
> +#define __my_cpu_offset get_paca()->data_offset
>  #define per_cpu_offset(x) (__per_cpu_offset(x))
>  
>  #endif /* CONFIG_SMP */

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-01-30 18:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 18:09 [PATCH 0/6] percpu: Per cpu code simplification linux-2.6.git travis
2008-01-30 18:09 ` travis
2008-01-30 18:09 ` [PATCH 1/6] modules: Fold percpu_modcopy into module.c linux-2.6.git travis
2008-01-30 18:09   ` travis
2008-01-30 18:09   ` travis
2008-01-30 18:09   ` travis
2008-01-30 18:09 ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA linux-2.6.git travis
2008-01-30 18:09   ` travis
2008-01-30 18:09   ` travis
2008-01-30 18:09   ` travis
2008-01-30 21:50   ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA Ingo Molnar
2008-01-30 21:50     ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA linux-2.6.git Ingo Molnar
2008-01-30 21:50     ` Ingo Molnar
2008-01-30 21:50     ` Ingo Molnar
2008-01-30 21:57     ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA Mike Travis
2008-01-30 21:57       ` [PATCH 2/6] percpu: Change Kconfig to HAVE_SETUP_PER_CPU_AREA linux-2.6.git Mike Travis
2008-01-30 21:57       ` Mike Travis
2008-01-30 21:57       ` Mike Travis
2008-01-30 18:09 ` [PATCH 3/6] sparc64: Use generic percpu linux-2.6.git travis
2008-01-30 18:09   ` travis
2008-01-30 21:52   ` Ingo Molnar
2008-01-30 21:52     ` Ingo Molnar
2008-01-31  1:03     ` David Miller
2008-01-31  1:03       ` David Miller, Ingo Molnar
2008-01-30 18:09 ` [PATCH 4/6] ia64: " travis
2008-01-30 18:09   ` travis
2008-01-30 18:09   ` travis
2008-01-30 18:09 ` [PATCH 5/6] powerpc: Use generic per cpu linux-2.6.git travis
2008-01-30 18:09   ` travis
2008-01-30 18:28   ` Ingo Molnar
2008-01-30 18:28     ` Ingo Molnar
2008-01-30 18:38     ` Mike Travis [this message]
2008-01-30 18:38       ` Mike Travis
2008-01-30 18:09 ` [PATCH 6/6] s390: Use generic percpu linux-2.6.git travis
2008-01-30 18:09   ` travis
2008-01-30 21:53   ` Ingo Molnar
2008-01-30 21:53     ` Ingo Molnar
2008-01-31  8:32     ` Martin Schwidefsky
2008-01-31  8:32       ` Martin Schwidefsky
2008-01-31  8:50       ` Ingo Molnar
2008-01-31  8:50         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A0C441.4020502@sgi.com \
    --to=travis@sgi.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.