From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net,
Andrzej Zaborowsi <balrogg@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] Don't explicitly set BAR values for VMware VGA
Date: Sun, 24 Feb 2008 09:09:18 +0200 [thread overview]
Message-ID: <47C1181E.6010304@qumranet.com> (raw)
In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com>
Anthony Liguori wrote:
> Right now we set explict base addresses for the PCI IO regions in the VMware
> VGA device. We don't register the second region at all and instead directly
> map the physical memory.
>
> The problem is, the addresses we're setting in the BAR is not taken into
> account in the e820 mapping.
>
> This patch removes the explicit BARs and registers the second region through
> the normal PCI code.
>
> I've only tested with a Linux guest and the open source VMware VGA driver.
>
> This patch needs -p2 to apply against the QEMU CVS tree.
>
>
Since it seems like qemu will apply this soon, I'll pick it up via the
next merge.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Don't explicitly set BAR values for VMware VGA
Date: Sun, 24 Feb 2008 09:09:18 +0200 [thread overview]
Message-ID: <47C1181E.6010304@qumranet.com> (raw)
In-Reply-To: <1203709210-23314-1-git-send-email-aliguori@us.ibm.com>
Anthony Liguori wrote:
> Right now we set explict base addresses for the PCI IO regions in the VMware
> VGA device. We don't register the second region at all and instead directly
> map the physical memory.
>
> The problem is, the addresses we're setting in the BAR is not taken into
> account in the e820 mapping.
>
> This patch removes the explicit BARs and registers the second region through
> the normal PCI code.
>
> I've only tested with a Linux guest and the open source VMware VGA driver.
>
> This patch needs -p2 to apply against the QEMU CVS tree.
>
>
Since it seems like qemu will apply this soon, I'll pick it up via the
next merge.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-02-24 7:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 19:40 [PATCH] Don't explicitly set BAR values for VMware VGA Anthony Liguori
2008-02-22 19:40 ` [Qemu-devel] " Anthony Liguori
2008-02-22 19:40 ` [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON Anthony Liguori
2008-02-24 8:31 ` Avi Kivity
2008-02-24 15:16 ` Anthony Liguori
2008-02-24 15:38 ` Avi Kivity
2008-02-22 19:40 ` [PATCH 2/3] Factor out the VGA vram mapping updating routine Anthony Liguori
2008-02-22 19:40 ` [PATCH 3/3] Enable VGA optimization for VMware VGA Anthony Liguori
2008-02-22 22:29 ` [PATCH] Don't explicitly set BAR values " Anthony Liguori
2008-02-22 22:29 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-02-22 23:45 ` andrzej zaborowski
2008-02-22 23:45 ` [Qemu-devel] " andrzej zaborowski
2008-02-23 0:03 ` Anthony Liguori
2008-02-23 0:03 ` [Qemu-devel] " Anthony Liguori
2008-02-23 1:02 ` andrzej zaborowski
2008-02-23 1:02 ` [Qemu-devel] " andrzej zaborowski
2008-02-23 22:59 ` Anthony Liguori
2008-02-23 22:59 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-02-24 7:09 ` Avi Kivity [this message]
2008-02-24 7:09 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C1181E.6010304@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=balrogg@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.