From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Memory Resource Controller Add Boot Option
Date: Mon, 25 Feb 2008 23:07:05 +0530 [thread overview]
Message-ID: <47C2FCC1.7090203@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830802250932s5eaa3bcchbfc49fe0e76d3f7d@mail.gmail.com>
Paul Menage wrote:
> On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> I thought about it, but it did not work out all that well. The reason being,
>> that the memory controller is called in from places besides cgroup.
>> mem_cgroup_charge_common() for example is called from several places in mm.
>> Calling into cgroups to check, enabled/disabled did not seem right.
>
> You wouldn't need to call into cgroups - if it's a flag in the subsys
> object (which is defined in memcontrol.c) you'd just say
>
> if (mem_cgroup_subsys.disabled) {
> ...
> }
>
> I'll send out a prototype for comment.
Sure thing, if css has the flag, then it would nice. Could you wrap it up to say
something like css_disabled(&mem_cgroup_subsys)
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Memory Resource Controller Add Boot Option
Date: Mon, 25 Feb 2008 23:07:05 +0530 [thread overview]
Message-ID: <47C2FCC1.7090203@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830802250932s5eaa3bcchbfc49fe0e76d3f7d@mail.gmail.com>
Paul Menage wrote:
> On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> I thought about it, but it did not work out all that well. The reason being,
>> that the memory controller is called in from places besides cgroup.
>> mem_cgroup_charge_common() for example is called from several places in mm.
>> Calling into cgroups to check, enabled/disabled did not seem right.
>
> You wouldn't need to call into cgroups - if it's a flag in the subsys
> object (which is defined in memcontrol.c) you'd just say
>
> if (mem_cgroup_subsys.disabled) {
> ...
> }
>
> I'll send out a prototype for comment.
Sure thing, if css has the flag, then it would nice. Could you wrap it up to say
something like css_disabled(&mem_cgroup_subsys)
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-25 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 11:55 [PATCH] Memory controller rename to Memory Resource Controller Balbir Singh
2008-02-25 11:55 ` Balbir Singh
2008-02-25 11:55 ` [PATCH] Memory Resource Controller Add Boot Option Balbir Singh
2008-02-25 11:55 ` Balbir Singh
2008-02-25 16:16 ` Paul Menage
2008-02-25 16:16 ` Paul Menage
2008-02-25 17:18 ` Balbir Singh
2008-02-25 17:18 ` Balbir Singh
2008-02-25 17:32 ` Paul Menage
2008-02-25 17:32 ` Paul Menage
2008-02-25 17:37 ` Balbir Singh [this message]
2008-02-25 17:37 ` Balbir Singh
2008-02-25 18:54 ` Paul Menage
2008-02-25 18:54 ` Paul Menage
2008-02-26 3:01 ` Li Zefan
2008-02-26 3:01 ` Li Zefan
2008-02-26 6:59 ` Hirokazu Takahashi
2008-02-26 6:59 ` Hirokazu Takahashi
2008-02-26 8:58 ` Paul Menage
2008-02-26 8:58 ` Paul Menage
2008-02-26 9:05 ` Li Zefan
2008-02-26 9:05 ` Li Zefan
2008-03-05 16:11 ` Balbir Singh
2008-03-05 16:11 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C2FCC1.7090203@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.