From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: balbir@linux.vnet.ibm.com,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
linux-kernel@vger.kernel.org, taka@valinux.co.jp,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Memory Resource Controller Add Boot Option
Date: Tue, 26 Feb 2008 17:05:14 +0800 [thread overview]
Message-ID: <47C3D64A.6080709@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830802260058m28d8f46djc83f47e19e2946a7@mail.gmail.com>
Paul Menage wrote:
> On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> >
>> > - foo doesn't show up in /proc/cgroups
>>
>> Or we can print out the disable flag, maybe this will be better?
>> Because we can distinguish from disabled and not compiled in from
>>
>> /proc/cgroups.
>
> Certainly possible, if people felt it was useful.
>
>> > - foo isn't auto-mounted if you mount all cgroups in a single hierarchy
>> > - foo isn't visible as an individually mountable subsystem
>>
>> You mentioned in a previous mail if we mount a disabled subsystem we
>> will get an error. Here we just ignore the mount option. Which makes
>> more sense ?
>>
>
> No, we don't ignore the mount option - we give an error since it
> doesn't refer to a valid subsystem. (And in the first case there is no
> mount option).
>
You are write, -ENOENT will be returned in this case. I made a mistake when
reading the prototype patch, thanks for the clarification. :)
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: balbir@linux.vnet.ibm.com,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
linux-kernel@vger.kernel.org, taka@valinux.co.jp,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Memory Resource Controller Add Boot Option
Date: Tue, 26 Feb 2008 17:05:14 +0800 [thread overview]
Message-ID: <47C3D64A.6080709@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830802260058m28d8f46djc83f47e19e2946a7@mail.gmail.com>
Paul Menage wrote:
> On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> >
>> > - foo doesn't show up in /proc/cgroups
>>
>> Or we can print out the disable flag, maybe this will be better?
>> Because we can distinguish from disabled and not compiled in from
>>
>> /proc/cgroups.
>
> Certainly possible, if people felt it was useful.
>
>> > - foo isn't auto-mounted if you mount all cgroups in a single hierarchy
>> > - foo isn't visible as an individually mountable subsystem
>>
>> You mentioned in a previous mail if we mount a disabled subsystem we
>> will get an error. Here we just ignore the mount option. Which makes
>> more sense ?
>>
>
> No, we don't ignore the mount option - we give an error since it
> doesn't refer to a valid subsystem. (And in the first case there is no
> mount option).
>
You are write, -ENOENT will be returned in this case. I made a mistake when
reading the prototype patch, thanks for the clarification. :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-26 9:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 11:55 [PATCH] Memory controller rename to Memory Resource Controller Balbir Singh
2008-02-25 11:55 ` Balbir Singh
2008-02-25 11:55 ` [PATCH] Memory Resource Controller Add Boot Option Balbir Singh
2008-02-25 11:55 ` Balbir Singh
2008-02-25 16:16 ` Paul Menage
2008-02-25 16:16 ` Paul Menage
2008-02-25 17:18 ` Balbir Singh
2008-02-25 17:18 ` Balbir Singh
2008-02-25 17:32 ` Paul Menage
2008-02-25 17:32 ` Paul Menage
2008-02-25 17:37 ` Balbir Singh
2008-02-25 17:37 ` Balbir Singh
2008-02-25 18:54 ` Paul Menage
2008-02-25 18:54 ` Paul Menage
2008-02-26 3:01 ` Li Zefan
2008-02-26 3:01 ` Li Zefan
2008-02-26 6:59 ` Hirokazu Takahashi
2008-02-26 6:59 ` Hirokazu Takahashi
2008-02-26 8:58 ` Paul Menage
2008-02-26 8:58 ` Paul Menage
2008-02-26 9:05 ` Li Zefan [this message]
2008-02-26 9:05 ` Li Zefan
2008-03-05 16:11 ` Balbir Singh
2008-03-05 16:11 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C3D64A.6080709@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.