All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabian Greffrath <greffrath@leat.rub.de>
To: The development of GRUB 2 <grub-devel@gnu.org>,
	Robert Millan <rmh@aybabtu.com>
Subject: [NEW PATCH] os-prober output parser
Date: Wed, 05 Mar 2008 13:27:56 +0100	[thread overview]
Message-ID: <47CE91CC.5010603@leat.rub.de> (raw)
In-Reply-To: <20080303210656.GD22431@thorin>

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

I have improved the script a little bit; in particular I moved the 
tests for the required software to the beginning of the script and let 
it gracefully 'exit 0' if anything is missing.

Let me comment on these tests:
- The first test (lines 19-22) is to check if grub-probe is recent 
enough to support the '--device' option. I have changed this to grep 
for it in the '--help' output instead of test-probing a given device, 
since you never know if a device.map allready exists (imaging booting 
from knoppix).
- I have changed the second test (24-27) to not utilize the 'which' 
utility anymore. It's in the debianutils package and I don't know if 
there's a chance that this is installed on non-Debian systems. On the 
other hand, we are utilizing os-prober which is Debian-only at the 
moment...
- The third test (30-33) is redundant, strictly speaking. The script 
will never enter the for/do loop if the os-prober output is empty. 
However, I found it reasonably to 'exit 0' before even attempting to 
enter the loop, YMMV. If it doesn't suit you, it can be removed safely.

Furthermore I have removed the 'hurd' stub. For the time beeing, HURD 
kernels remain unsupported and throw a warning message just like 
macos* and all other !linux and !chain operating systems.

Best Regards,
Fabian

-- 
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath@leat.ruhr-uni-bochum.de

[-- Attachment #2: 30_os-prober --]
[-- Type: text/plain, Size: 2725 bytes --]

#! /bin/sh -e

# update-grub helper script.
# Copyright (C) 2006,2007,2008  Free Software Foundation, Inc.
#
# GRUB is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# GRUB is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with GRUB.  If not, see <http://www.gnu.org/licenses/>.

if [ -z "`grub-probe --help 2> /dev/null | grep '\-d,\ \-\-device'`" ] ; then
  # grub-probe does not support '--device' option yet (introduced in 1.96+20080228)
  exit 0
fi

if [ -x /usr/bin/os-prober -a -x /usr/bin/linux-boot-prober ] ; then : ; else
  # os-prober/linux-boot-prober not installed
  exit 0
fi

OSPROBED="`os-prober 2> /dev/null | tr ' ' '^' | paste -s -d ' '`"
if [ -z "${OSPROBED}" ] ; then
  # empty os-prober output, nothing doing
  exit 0
fi

for OS in ${OSPROBED} ; do
  DEVICE="`echo ${OS} | cut -d ':' -f 1`"
  LONGNAME="`echo ${OS} | cut -d ':' -f 2 | tr '^' ' '`"
  LABEL="`echo ${OS} | cut -d ':' -f 3 | tr '^' ' '`"
  BOOT="`echo ${OS} | cut -d ':' -f 4`"

  if [ -z "${LONGNAME}" ] ; then
    LONGNAME="${LABEL}"
  fi

  echo "Found ${LONGNAME} on ${DEVICE}" >&2

  case ${BOOT} in
    chain)
      CHAINROOT="`grub-probe --target=drive --device ${DEVICE} 2> /dev/null`"

      cat << EOF
menuentry "${LONGNAME} (on ${DEVICE})" {
	set root=${CHAINROOT}
	chainloader +1
}
EOF
    ;;
    linux)
      LINUXPROBED="`linux-boot-prober ${DEVICE} 2> /dev/null | tr ' ' '^' | paste -s -d ' '`"
 
      for LINUX in ${LINUXPROBED} ; do
        LROOT="`echo ${LINUX} | cut -d ':' -f 1`"
        LBOOT="`echo ${LINUX} | cut -d ':' -f 2`"
        LLABEL="`echo ${LINUX} | cut -d ':' -f 3 | tr '^' ' '`"
        LKERNEL="`echo ${LINUX} | cut -d ':' -f 4`"
        LINITRD="`echo ${LINUX} | cut -d ':' -f 5`"
        LPARAMS="`echo ${LINUX} | cut -d ':' -f 6- | tr '^' ' '`"

        LINUXROOT="`grub-probe --target=drive --device ${LBOOT} 2> /dev/null`"

        if [ -z "${LLABEL}" ] ; then
          LLABEL="${LONGNAME}"
        fi

        cat << EOF
menuentry "${LLABEL} (on ${DEVICE})" {
	set root=${LINUXROOT}
	linux ${LKERNEL} ${LPARAMS}
EOF
        if [ -n "${LINITRD}" ] ; then
          cat << EOF
	initrd ${LINITRD}
EOF
        fi
        cat << EOF
}
EOF
      done
    ;;
    hurd|*)
      echo "  ${LONGNAME} is not yet supported by update-grub." >&2
    ;;
  esac
done

  parent reply	other threads:[~2008-03-05 12:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 13:17 [PATCH] Add option to grub-probe to accept system devices as arguments Fabian Greffrath
2008-02-13 13:03 ` Fabian Greffrath
2008-02-13 15:42 ` Robert Millan
2008-02-13 16:51   ` Fabian Greffrath
2008-02-13 19:35     ` Robert Millan
2008-02-14  8:33       ` Fabian Greffrath
2008-02-17 13:42         ` Robert Millan
2008-02-18 12:54           ` Fabian Greffrath
2008-02-20 14:14           ` Fabian Greffrath
2008-02-22 14:32           ` [NEW PATCH] " Fabian Greffrath
2008-02-22 15:36             ` Fabian Greffrath
2008-02-24 15:22               ` Robert Millan
2008-02-25  9:49                 ` Fabian Greffrath
2008-02-25 14:20                   ` Robert Millan
2008-02-28  7:26                     ` Fabian Greffrath
2008-02-28 10:10                       ` Robert Millan
2008-02-28 10:28                         ` Fabian Greffrath
2008-02-28 10:41                           ` Robert Millan
2008-02-28 11:46                             ` Fabian Greffrath
2008-02-28 17:07                               ` Robert Millan
2008-02-29  8:33                                 ` Fabian Greffrath
2008-03-03 21:06                                   ` Robert Millan
2008-03-04  7:57                                     ` Fabian Greffrath
2008-03-05 12:27                                     ` Fabian Greffrath [this message]
2008-03-13  7:56                                       ` [NEW PATCH] os-prober output parser Fabian Greffrath
2008-03-19 14:38                                       ` Robert Millan
2008-03-19 15:18                                         ` Fabian Greffrath
2008-03-19 16:10                                           ` Robert Millan
2008-03-20 10:02                                             ` Fabian Greffrath
2008-03-20 10:36                                               ` Robert Millan
2008-03-25  7:27                                                 ` Fabian Greffrath
2008-04-07  8:39                                                   ` Fabian Greffrath
2008-04-09  8:32                                                     ` Fabian Greffrath
2008-04-09 10:11                                                       ` Robert Millan
2008-04-09 12:41                                                         ` Fabian Greffrath
2008-04-13 10:52                                                     ` Robert Millan
2008-04-14 11:11                                                       ` Fabian Greffrath
2008-02-29 13:46                                 ` [NEW PATCH] Add option to grub-probe to accept system devices as arguments Fabian Greffrath
2008-03-03 20:58                                   ` Robert Millan
2008-02-24 15:23             ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CE91CC.5010603@leat.rub.de \
    --to=greffrath@leat.rub.de \
    --cc=grub-devel@gnu.org \
    --cc=rmh@aybabtu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.