Re: [NEW PATCH] os-prober output parser

[Robert Millan <rmh@aybabtu.com>]

On Wed, Mar 19, 2008 at 04:18:42PM +0100, Fabian Greffrath wrote:
> >When run in the console it makes Linux spit a truckload of information 
> >about
> >filesystem probing.  Is there any way we could avoid this?
> 
> I don't know why this happens since I allready divert stderr to 
> /dev/null in the os-prober call. Maybe this is a bug in os-prober itself.

They're printed directly by Linux.  No idea how to stop that, but I don't think
this problem is a showstopper anyway (they're always printed to /dev/console).

> >How do you prevent it from detecting your own partition?  I didn't see any
> >provisions for this.
> 
> I don't have to. That's the way os-prober works.

Ok.

> >Whops.  This tag (utf-8 stuff?) breaks the Linux shebang parser :-)
> 
> Yes, sorry. I am forced to store the file on a Windows partition in 
> order to send it as an email attachment. Don't ask me about UTF8 and 
> Windows. ;)

Argh.. :-)

> >Can we avoid hardcoding their absolute path?
> 
> Yes, via the 'which' command - as has been implemented in previous 
> versions of this script. But back then you had objections against it...

I prefer which myself, but IIRC Okuji said this isn't as much portable.  The
alternative is to do it like grub-install:

  set $grub_setup dummy
  if test -f "$1"; then
      :
  else
      echo "$1: Not found." 1>&2
      exit 1
  fi

which is very ugly if you ask me.  Okuji, do you have any comments on this?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)