All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: "Yoshinori K. Okuji" <okuji@enbug.org>
Subject: Re: [NEW PATCH] os-prober output parser
Date: Thu, 20 Mar 2008 11:36:26 +0100	[thread overview]
Message-ID: <20080320103626.GA10347@thorin> (raw)
In-Reply-To: <47E2363B.3020509@leat.rub.de>

On Thu, Mar 20, 2008 at 11:02:35AM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >which is very ugly if you ask me.  Okuji, do you have any comments on this?
> 
> Apart from this issue, is the script allright?

Also, you can remove this check now:

if [ -z "`grub-probe --help 2> /dev/null | grep '\-d,\ \-\-device'`" ] ; then
  # grub-probe does not support '--device' option yet (introduced in 1.96+20080228)
  exit 0
fi

and please include a ChangeLog entry.  As far as I'm concerned, there's nothing
else missing.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-03-20 10:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 13:17 [PATCH] Add option to grub-probe to accept system devices as arguments Fabian Greffrath
2008-02-13 13:03 ` Fabian Greffrath
2008-02-13 15:42 ` Robert Millan
2008-02-13 16:51   ` Fabian Greffrath
2008-02-13 19:35     ` Robert Millan
2008-02-14  8:33       ` Fabian Greffrath
2008-02-17 13:42         ` Robert Millan
2008-02-18 12:54           ` Fabian Greffrath
2008-02-20 14:14           ` Fabian Greffrath
2008-02-22 14:32           ` [NEW PATCH] " Fabian Greffrath
2008-02-22 15:36             ` Fabian Greffrath
2008-02-24 15:22               ` Robert Millan
2008-02-25  9:49                 ` Fabian Greffrath
2008-02-25 14:20                   ` Robert Millan
2008-02-28  7:26                     ` Fabian Greffrath
2008-02-28 10:10                       ` Robert Millan
2008-02-28 10:28                         ` Fabian Greffrath
2008-02-28 10:41                           ` Robert Millan
2008-02-28 11:46                             ` Fabian Greffrath
2008-02-28 17:07                               ` Robert Millan
2008-02-29  8:33                                 ` Fabian Greffrath
2008-03-03 21:06                                   ` Robert Millan
2008-03-04  7:57                                     ` Fabian Greffrath
2008-03-05 12:27                                     ` [NEW PATCH] os-prober output parser Fabian Greffrath
2008-03-13  7:56                                       ` Fabian Greffrath
2008-03-19 14:38                                       ` Robert Millan
2008-03-19 15:18                                         ` Fabian Greffrath
2008-03-19 16:10                                           ` Robert Millan
2008-03-20 10:02                                             ` Fabian Greffrath
2008-03-20 10:36                                               ` Robert Millan [this message]
2008-03-25  7:27                                                 ` Fabian Greffrath
2008-04-07  8:39                                                   ` Fabian Greffrath
2008-04-09  8:32                                                     ` Fabian Greffrath
2008-04-09 10:11                                                       ` Robert Millan
2008-04-09 12:41                                                         ` Fabian Greffrath
2008-04-13 10:52                                                     ` Robert Millan
2008-04-14 11:11                                                       ` Fabian Greffrath
2008-02-29 13:46                                 ` [NEW PATCH] Add option to grub-probe to accept system devices as arguments Fabian Greffrath
2008-03-03 20:58                                   ` Robert Millan
2008-02-24 15:23             ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080320103626.GA10347@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    --cc=okuji@enbug.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.