All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: fix variable_test_bit()asmconstraints
Date: Fri, 14 Mar 2008 14:11:18 +0000	[thread overview]
Message-ID: <47DA9596.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C40034C8.15036%keir.fraser@eu.citrix.com>

>Regarding your other reply: I would actually be happy to change the bitops
>to work with longs only. I suspect, and would need to have demonstrated
>otherwise, that supporting bitops on arbitrary-width fields down to the
>instruction level is not really worthwhile. Either way, I accept that what
>we do now is dubious at best.

Hmm, change it to work with longs only but also make it work without
casts? You mean then change all places where bitops are applied to
exclusively use 'unsigned long' as the fundamental type? I didn't look
at the number of places that would require changing, but I'm afraid it'd
be quite a few (and it might get you further away from Linux originals
in some cases).

Jan

  reply	other threads:[~2008-03-14 14:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 11:23 [PATCH] x86: fix variable_test_bit() asm constraints Jan Beulich
2008-03-14 11:55 ` Keir Fraser
2008-03-14 11:59   ` Keir Fraser
2008-03-14 13:46     ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 12:06   ` [PATCH] x86: fix variable_test_bit() asm constraints Keir Fraser
2008-03-14 13:51   ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 13:57     ` Keir Fraser
2008-03-14 14:11       ` Jan Beulich [this message]
2008-03-14 15:37         ` [PATCH] x86: fix variable_test_bit()asmconstraints Keir Fraser
2008-03-14 16:42           ` Jan Beulich
2008-03-14 17:08             ` Keir Fraser
2008-03-16 14:08               ` Keir Fraser
2008-03-14 13:59     ` [PATCH] x86: fix variable_test_bit() asmconstraints Samuel Thibault
2008-03-14 14:04       ` Keir Fraser
2008-03-14 14:18       ` Jan Beulich
2008-03-14 15:17       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DA9596.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.