From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] x86: fix variable_test_bit() asmconstraints
Date: Fri, 14 Mar 2008 13:59:38 +0000 [thread overview]
Message-ID: <20080314135938.GN4358@implementation.uk.xensource.com> (raw)
In-Reply-To: <47DA90EE.76E4.0078.0@novell.com>
Jan Beulich, le Fri 14 Mar 2008 13:51:26 +0000, a écrit :
> >memory-clobber would be needed for the atomic ops, but a dummy memory
> >operand would suffice for non-atomic ops. I used memory clobber everywhere
>
> Atomic ops imply a barrier (otherwise the compiler can defeat the
> purpose of the atomic operation). The non-atomic ones don't need a
> dummy operand, but one that precisely describes the place in memory
> that changes.
Mmm, won't that unnecessarily make the compiler put code to compute that
place?
Samuel
next prev parent reply other threads:[~2008-03-14 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 11:23 [PATCH] x86: fix variable_test_bit() asm constraints Jan Beulich
2008-03-14 11:55 ` Keir Fraser
2008-03-14 11:59 ` Keir Fraser
2008-03-14 13:46 ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 12:06 ` [PATCH] x86: fix variable_test_bit() asm constraints Keir Fraser
2008-03-14 13:51 ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 13:57 ` Keir Fraser
2008-03-14 14:11 ` [PATCH] x86: fix variable_test_bit()asmconstraints Jan Beulich
2008-03-14 15:37 ` Keir Fraser
2008-03-14 16:42 ` Jan Beulich
2008-03-14 17:08 ` Keir Fraser
2008-03-16 14:08 ` Keir Fraser
2008-03-14 13:59 ` Samuel Thibault [this message]
2008-03-14 14:04 ` [PATCH] x86: fix variable_test_bit() asmconstraints Keir Fraser
2008-03-14 14:18 ` Jan Beulich
2008-03-14 15:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314135938.GN4358@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.