From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: fix variable_test_bit() asmconstraints
Date: Fri, 14 Mar 2008 13:57:28 +0000 [thread overview]
Message-ID: <C40034C8.15036%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <47DA90EE.76E4.0078.0@novell.com>
On 14/3/08 13:51, "Jan Beulich" <jbeulich@novell.com> wrote:
>> because at least I'm certain that works. Same for 'asm volatile'. We've had
>> various problems with the bitops before, and I just want the darn things to
>> work!
>
> Okay, if you feel that way then I guess I won't propose changing it,
> at the expense of slightly worse code generation.
Frankly I'm scared to change it for the minuscule benefit we would derive
from it.
Regarding your other reply: I would actually be happy to change the bitops
to work with longs only. I suspect, and would need to have demonstrated
otherwise, that supporting bitops on arbitrary-width fields down to the
instruction level is not really worthwhile. Either way, I accept that what
we do now is dubious at best.
-- Keir
next prev parent reply other threads:[~2008-03-14 13:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 11:23 [PATCH] x86: fix variable_test_bit() asm constraints Jan Beulich
2008-03-14 11:55 ` Keir Fraser
2008-03-14 11:59 ` Keir Fraser
2008-03-14 13:46 ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 12:06 ` [PATCH] x86: fix variable_test_bit() asm constraints Keir Fraser
2008-03-14 13:51 ` [PATCH] x86: fix variable_test_bit() asmconstraints Jan Beulich
2008-03-14 13:57 ` Keir Fraser [this message]
2008-03-14 14:11 ` [PATCH] x86: fix variable_test_bit()asmconstraints Jan Beulich
2008-03-14 15:37 ` Keir Fraser
2008-03-14 16:42 ` Jan Beulich
2008-03-14 17:08 ` Keir Fraser
2008-03-16 14:08 ` Keir Fraser
2008-03-14 13:59 ` [PATCH] x86: fix variable_test_bit() asmconstraints Samuel Thibault
2008-03-14 14:04 ` Keir Fraser
2008-03-14 14:18 ` Jan Beulich
2008-03-14 15:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C40034C8.15036%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.