From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Julia Lawall <julia@diku.dk>
Cc: jeffrey.t.kirsher@intel.com, ayyappan.veeraiyan@intel.com,
john.ronciak@intel.com, jesse.brandeburg@intel.com,
auke-jan.h.kok@intel.com, e1000-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
Date: Mon, 17 Mar 2008 16:37:48 +0000 [thread overview]
Message-ID: <47DE9E5C.6080603@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803151703520.24178@ask.diku.dk>
OK, i'll pass it along. ty
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable num_group_tail_writes is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> drivers/net/ixgb/ixgb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> --- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
> +++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
> @@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
> struct ixgb_buffer *buffer_info;
> struct sk_buff *skb;
> unsigned int i;
> - int num_group_tail_writes;
> long cleancount;
>
> i = rx_ring->next_to_use;
> buffer_info = &rx_ring->buffer_info[i];
> cleancount = IXGB_DESC_UNUSED(rx_ring);
>
> - num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
>
> /* leave three descriptors unused */
> while(--cleancount > 2) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Julia Lawall <julia@diku.dk>
Cc: jeffrey.t.kirsher@intel.com, ayyappan.veeraiyan@intel.com,
john.ronciak@intel.com, jesse.brandeburg@intel.com,
auke-jan.h.kok@intel.com, e1000-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
Date: Mon, 17 Mar 2008 09:37:48 -0700 [thread overview]
Message-ID: <47DE9E5C.6080603@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803151703520.24178@ask.diku.dk>
OK, i'll pass it along. ty
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable num_group_tail_writes is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> drivers/net/ixgb/ixgb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> --- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
> +++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
> @@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
> struct ixgb_buffer *buffer_info;
> struct sk_buff *skb;
> unsigned int i;
> - int num_group_tail_writes;
> long cleancount;
>
> i = rx_ring->next_to_use;
> buffer_info = &rx_ring->buffer_info[i];
> cleancount = IXGB_DESC_UNUSED(rx_ring);
>
> - num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
>
> /* leave three descriptors unused */
> while(--cleancount > 2) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2008-03-17 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-15 16:04 [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable Julia Lawall
2008-03-15 16:04 ` Julia Lawall
2008-03-17 16:37 ` Kok, Auke [this message]
2008-03-17 16:37 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DE9E5C.6080603@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=ayyappan.veeraiyan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.