* [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
@ 2008-03-15 16:04 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2008-03-15 16:04 UTC (permalink / raw)
To: jeffrey.t.kirsher, ayyappan.veeraiyan, john.ronciak,
jesse.brandeburg, auke-jan.h.kok, e1000-devel, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable num_group_tail_writes is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/ixgb/ixgb_main.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
--- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
@@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
struct ixgb_buffer *buffer_info;
struct sk_buff *skb;
unsigned int i;
- int num_group_tail_writes;
long cleancount;
i = rx_ring->next_to_use;
buffer_info = &rx_ring->buffer_info[i];
cleancount = IXGB_DESC_UNUSED(rx_ring);
- num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
/* leave three descriptors unused */
while(--cleancount > 2) {
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
@ 2008-03-15 16:04 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2008-03-15 16:04 UTC (permalink / raw)
To: jeffrey.t.kirsher, ayyappan.veeraiyan, john.ronciak,
jesse.brandeburg, auke-jan.h.kok, e1000-devel, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
The variable num_group_tail_writes is initialized but never used otherwise.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/ixgb/ixgb_main.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
--- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
@@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
struct ixgb_buffer *buffer_info;
struct sk_buff *skb;
unsigned int i;
- int num_group_tail_writes;
long cleancount;
i = rx_ring->next_to_use;
buffer_info = &rx_ring->buffer_info[i];
cleancount = IXGB_DESC_UNUSED(rx_ring);
- num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
/* leave three descriptors unused */
while(--cleancount > 2) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
2008-03-15 16:04 ` Julia Lawall
@ 2008-03-17 16:37 ` Kok, Auke
-1 siblings, 0 replies; 4+ messages in thread
From: Kok, Auke @ 2008-03-17 16:37 UTC (permalink / raw)
To: Julia Lawall
Cc: jeffrey.t.kirsher, ayyappan.veeraiyan, john.ronciak,
jesse.brandeburg, auke-jan.h.kok, e1000-devel, linux-kernel,
kernel-janitors
OK, i'll pass it along. ty
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable num_group_tail_writes is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> drivers/net/ixgb/ixgb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> --- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
> +++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
> @@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
> struct ixgb_buffer *buffer_info;
> struct sk_buff *skb;
> unsigned int i;
> - int num_group_tail_writes;
> long cleancount;
>
> i = rx_ring->next_to_use;
> buffer_info = &rx_ring->buffer_info[i];
> cleancount = IXGB_DESC_UNUSED(rx_ring);
>
> - num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
>
> /* leave three descriptors unused */
> while(--cleancount > 2) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable
@ 2008-03-17 16:37 ` Kok, Auke
0 siblings, 0 replies; 4+ messages in thread
From: Kok, Auke @ 2008-03-17 16:37 UTC (permalink / raw)
To: Julia Lawall
Cc: jeffrey.t.kirsher, ayyappan.veeraiyan, john.ronciak,
jesse.brandeburg, auke-jan.h.kok, e1000-devel, linux-kernel,
kernel-janitors
OK, i'll pass it along. ty
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The variable num_group_tail_writes is initialized but never used otherwise.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
> drivers/net/ixgb/ixgb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> --- a/drivers/net/ixgb/ixgb_main.c 2008-03-12 14:13:13.000000000 +0100
> +++ b/drivers/net/ixgb/ixgb_main.c 2008-03-15 11:16:23.000000000 +0100
> @@ -2088,14 +2088,12 @@ ixgb_alloc_rx_buffers(struct ixgb_adapte
> struct ixgb_buffer *buffer_info;
> struct sk_buff *skb;
> unsigned int i;
> - int num_group_tail_writes;
> long cleancount;
>
> i = rx_ring->next_to_use;
> buffer_info = &rx_ring->buffer_info[i];
> cleancount = IXGB_DESC_UNUSED(rx_ring);
>
> - num_group_tail_writes = IXGB_RX_BUFFER_WRITE;
>
> /* leave three descriptors unused */
> while(--cleancount > 2) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-17 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-15 16:04 [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable Julia Lawall
2008-03-15 16:04 ` Julia Lawall
2008-03-17 16:37 ` Kok, Auke
2008-03-17 16:37 ` Kok, Auke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.