From: Patrick McHardy <kaber@trash.net>
To: jdike@addtoit.com
Cc: Linux Netdev List <netdev@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
Date: Wed, 26 Mar 2008 06:46:25 +0100 [thread overview]
Message-ID: <47E9E331.1010105@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1160 bytes --]
commit 00237037726efc587d55d65d6fd5357106ae7071
Author: Patrick McHardy <kaber@trash.net>
Date: Wed Mar 26 06:41:22 2008 +0100
[UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
IFF_ALLMULTI is an indication from the network stack to the driver
to disable multicast filters, drivers should never set it directly.
Since the UML networking device doesn't have any filtering capabilites,
it doesn't the set_multicast_list function at all, it is kept so userspace
can still issue SIOCADDMULTI/SIOCDELMULTI ioctls however.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 1e8f41a..1d43bdf 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -256,11 +256,7 @@ static struct net_device_stats *uml_net_get_stats(struct net_device *dev)
static void uml_net_set_multicast_list(struct net_device *dev)
{
- if (dev->flags & IFF_PROMISC)
- return;
- else if (dev->mc_count)
- dev->flags |= IFF_ALLMULTI;
- else dev->flags &= ~IFF_ALLMULTI;
+ return;
}
static void uml_net_tx_timeout(struct net_device *dev)
[-- Attachment #3: Type: text/plain, Size: 278 bytes --]
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
[-- Attachment #4: Type: text/plain, Size: 194 bytes --]
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: jdike@addtoit.com
Cc: user-mode-linux-devel@lists.sourceforge.net,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
Date: Wed, 26 Mar 2008 06:46:25 +0100 [thread overview]
Message-ID: <47E9E331.1010105@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1160 bytes --]
commit 00237037726efc587d55d65d6fd5357106ae7071
Author: Patrick McHardy <kaber@trash.net>
Date: Wed Mar 26 06:41:22 2008 +0100
[UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
IFF_ALLMULTI is an indication from the network stack to the driver
to disable multicast filters, drivers should never set it directly.
Since the UML networking device doesn't have any filtering capabilites,
it doesn't the set_multicast_list function at all, it is kept so userspace
can still issue SIOCADDMULTI/SIOCDELMULTI ioctls however.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 1e8f41a..1d43bdf 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -256,11 +256,7 @@ static struct net_device_stats *uml_net_get_stats(struct net_device *dev)
static void uml_net_set_multicast_list(struct net_device *dev)
{
- if (dev->flags & IFF_PROMISC)
- return;
- else if (dev->mc_count)
- dev->flags |= IFF_ALLMULTI;
- else dev->flags &= ~IFF_ALLMULTI;
+ return;
}
static void uml_net_tx_timeout(struct net_device *dev)
next reply other threads:[~2008-03-26 5:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 5:46 Patrick McHardy [this message]
2008-03-26 5:46 ` [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list Patrick McHardy
2008-03-26 6:10 ` [uml-devel] " Jeff Garzik
2008-03-26 6:10 ` Jeff Garzik
2008-03-26 6:13 ` [uml-devel] " Patrick McHardy
2008-03-26 6:13 ` Patrick McHardy
2008-03-26 7:16 ` [uml-devel] " David Miller
2008-03-26 7:16 ` David Miller
2008-03-31 14:09 ` [uml-devel] " Jeff Dike
2008-03-31 14:09 ` Jeff Dike
2008-03-31 17:46 ` [uml-devel] " Patrick McHardy
2008-03-31 17:46 ` Patrick McHardy
2008-04-01 15:39 ` [uml-devel] " Jeff Dike
2008-04-01 15:39 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E9E331.1010105@trash.net \
--to=kaber@trash.net \
--cc=jdike@addtoit.com \
--cc=netdev@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.