From: Patrick McHardy <kaber@trash.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
Date: Wed, 26 Mar 2008 07:13:51 +0100 [thread overview]
Message-ID: <47E9E99F.5080003@trash.net> (raw)
In-Reply-To: <47E9E8CD.1060408@garzik.org>
Jeff Garzik wrote:
>> static void uml_net_set_multicast_list(struct net_device *dev)
>> {
>> - if (dev->flags & IFF_PROMISC)
>> - return;
>> - else if (dev->mc_count)
>> - dev->flags |= IFF_ALLMULTI;
>> - else dev->flags &= ~IFF_ALLMULTI;
>> + return;
>> }
>
>
>
> Might as well just delete the hook at that point...
I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to
work on UML devices. I don't know if any userspace applications
check for errors when using these ioctls, this way nothing
can break.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list
Date: Wed, 26 Mar 2008 07:13:51 +0100 [thread overview]
Message-ID: <47E9E99F.5080003@trash.net> (raw)
In-Reply-To: <47E9E8CD.1060408@garzik.org>
Jeff Garzik wrote:
>> static void uml_net_set_multicast_list(struct net_device *dev)
>> {
>> - if (dev->flags & IFF_PROMISC)
>> - return;
>> - else if (dev->mc_count)
>> - dev->flags |= IFF_ALLMULTI;
>> - else dev->flags &= ~IFF_ALLMULTI;
>> + return;
>> }
>
>
>
> Might as well just delete the hook at that point...
I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to
work on UML devices. I don't know if any userspace applications
check for errors when using these ioctls, this way nothing
can break.
next prev parent reply other threads:[~2008-03-26 6:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 5:46 [uml-devel] [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list Patrick McHardy
2008-03-26 5:46 ` Patrick McHardy
2008-03-26 6:10 ` [uml-devel] " Jeff Garzik
2008-03-26 6:10 ` Jeff Garzik
2008-03-26 6:13 ` Patrick McHardy [this message]
2008-03-26 6:13 ` Patrick McHardy
2008-03-26 7:16 ` [uml-devel] " David Miller
2008-03-26 7:16 ` David Miller
2008-03-31 14:09 ` [uml-devel] " Jeff Dike
2008-03-31 14:09 ` Jeff Dike
2008-03-31 17:46 ` [uml-devel] " Patrick McHardy
2008-03-31 17:46 ` Patrick McHardy
2008-04-01 15:39 ` [uml-devel] " Jeff Dike
2008-04-01 15:39 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E9E99F.5080003@trash.net \
--to=kaber@trash.net \
--cc=jdike@addtoit.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.