Re: [RFC PATCH 26/26] UBIFS: include FS to compilation

[Artem Bityutskiy <dedekind@yandex.ru>]

Pekka Enberg wrote:
>>  +config UBIFS_FS_DEBUG_MSG_GEN
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_JRN
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_CMT
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_BUDG
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_LOG
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_TNC
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_LP
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_FIND
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_MNT
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_IO
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_GC
>>  +
>>  +config UBIFS_FS_DEBUG_MSG_SCAN
> 
> But these don't make much sense to me. Why would you want to be able
> to compile out printks at this granularity? Why not enable all of them
> when CONFIG_UBIFS_FS_DEBUG is enabled?

Well, its just more convenient for us. If I know the bug is somewhere in
the journal, I enable the journal messages - less flooding. We may
lessen the amount, but it is still handy to have some classes of
prints separate.

We will think how to lessen the amount and granularity of this.

> 
>>  +menu "Extra self-checks"
>>  +       depends on UBIFS_FS_DEBUG
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_MEMPRESS
> 
>>  +config UBIFS_FS_DEBUG_CHK_LPROPS
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_TNC
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_ORPH
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_IDX_SZ
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_OLD_IDX
>>  +
>>  +config UBIFS_FS_DEBUG_CHK_OTHER
>>  +
>>  +config UBIFS_FS_DEBUG_TEST_RCVRY
> 
> Why would you not want to enable all of these for development kernels?

Some of the checks are very heavy-weight. For example, the tree checking
functions scan the whole TNC/LPT B-tree, which means they read it from
flash, they check CRC, and they make sure the tree is consistent and
has sane data. They are very useful when hunting bugs, but they are too
slow to be always enabled.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)