All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Pavel Emelianov <xemul@openvz.org>,
	Hugh Dickins <hugh@veritas.com>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>,
	YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	linux-kernel@vger.kernel.org, taka@valinux.co.jp,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [-mm] Add an owner to the mm_struct (v8)
Date: Thu, 10 Apr 2008 14:39:27 +0530	[thread overview]
Message-ID: <47FDD947.8020600@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830804080029v1d8f2ff7g5254f32362fd7cb9@mail.gmail.com>

Paul Menage wrote:
> On Tue, Apr 8, 2008 at 12:05 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> Paul Menage wrote:
>>  > On Mon, Apr 7, 2008 at 11:52 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>>  >>  I agree, but like I said earlier, this was the easily available ready made
>>  >>  application I found. Do you know of any other highly threaded micro benchmark?
>>  >>
>>  >
>>  > How about a simple program that creates N threads that just sleep,
>>  > then has the main thread exit?
>>  >
>>
>>  That is not really representative of anything. I have that program handy. How do
>>  we measure the impact on throughput?
> 
> It's very representative of how much additional overhead in terms of
> mm->owner churn there is in a large multi-threaded application
> exiting, which is the thing that you're trying to optimize with the
> delayed thread group leader checks.
> 

I see almost no overhead after the notification change optimization (notify only
if owner belongs to a different cgroup).

My program creates n processes with k threads each and forces the thread group
leader to exit. For my experiment I created 10 processes with 800 threads each
(NOTE: you need to change ulimit -s for this to work).

I am going to remove the delay_group_leader() optimization and submit v9.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Pavel Emelianov <xemul@openvz.org>,
	Hugh Dickins <hugh@veritas.com>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>,
	YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	linux-kernel@vger.kernel.org, taka@valinux.co.jp,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [-mm] Add an owner to the mm_struct (v8)
Date: Thu, 10 Apr 2008 14:39:27 +0530	[thread overview]
Message-ID: <47FDD947.8020600@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830804080029v1d8f2ff7g5254f32362fd7cb9@mail.gmail.com>

Paul Menage wrote:
> On Tue, Apr 8, 2008 at 12:05 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> Paul Menage wrote:
>>  > On Mon, Apr 7, 2008 at 11:52 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>>  >>  I agree, but like I said earlier, this was the easily available ready made
>>  >>  application I found. Do you know of any other highly threaded micro benchmark?
>>  >>
>>  >
>>  > How about a simple program that creates N threads that just sleep,
>>  > then has the main thread exit?
>>  >
>>
>>  That is not really representative of anything. I have that program handy. How do
>>  we measure the impact on throughput?
> 
> It's very representative of how much additional overhead in terms of
> mm->owner churn there is in a large multi-threaded application
> exiting, which is the thing that you're trying to optimize with the
> delayed thread group leader checks.
> 

I see almost no overhead after the notification change optimization (notify only
if owner belongs to a different cgroup).

My program creates n processes with k threads each and forces the thread group
leader to exit. For my experiment I created 10 processes with 800 threads each
(NOTE: you need to change ulimit -s for this to work).

I am going to remove the delay_group_leader() optimization and submit v9.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-04-10  9:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04  8:05 [-mm] Add an owner to the mm_struct (v8) Balbir Singh
2008-04-04  8:12 ` Paul Menage
2008-04-04  8:28   ` Balbir Singh
2008-04-04  8:50     ` Paul Menage
2008-04-04  9:25       ` Balbir Singh
2008-04-04 19:11         ` Paul Menage
2008-04-05 14:47           ` Balbir Singh
2008-04-05 17:23             ` Paul Menage
2008-04-05 17:48               ` Balbir Singh
2008-04-05 17:57                 ` Paul Menage
2008-04-05 18:59                   ` Balbir Singh
2008-04-05 23:29                     ` Paul Menage
2008-04-06  5:38                       ` Balbir Singh
2008-04-08  6:37                         ` Paul Menage
2008-04-08  6:52                           ` Balbir Singh
2008-04-08  6:57                             ` Paul Menage
2008-04-08  7:05                               ` Balbir Singh
2008-04-08  7:29                                 ` Paul Menage
2008-04-10  9:09                                   ` Balbir Singh [this message]
2008-04-10  9:09                                     ` Balbir Singh
2008-04-05 23:31                     ` Paul Menage
2008-04-06  6:31                       ` Balbir Singh
2008-04-08  6:32                         ` Paul Menage
2008-04-07 22:09 ` Andrew Morton
2008-04-07 22:09   ` Andrew Morton
2008-04-08  2:39   ` Balbir Singh
2008-04-08  2:55     ` Andrew Morton
2008-04-09  0:42 ` KAMEZAWA Hiroyuki
2008-04-09  0:42   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FDD947.8020600@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=rientjes@google.com \
    --cc=skumar@linux.vnet.ibm.com \
    --cc=taka@valinux.co.jp \
    --cc=xemul@openvz.org \
    --cc=yamamoto@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.