All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
	linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup
Date: Mon, 14 Apr 2008 09:56:11 -0500	[thread overview]
Message-ID: <4803708B.1070009@freescale.com> (raw)
In-Reply-To: <6B2293E0-BE5E-4C2E-9A48-4E91079A7422@kernel.crashing.org>

Kumar Gala wrote:

> I say leave as you have it (UCC1 == cell-index = <1>).
> 
> Changing it so cell-index = <0> is just more confusing w/regards to  
> the docs.

I don't see anything in booting-without-of.txt that requires cell-index to start
at 0, however, the only other device that starts at 1 is SATA.  Even the SSI
starts at 0:

       - cell-index	  : the SSI, <0> = SSI1, <1> = SSI2, and so on

Although I don't want to make more work for Anton, my vote is to have cell-index
start at 0.  That is the convention.  It's too late to fix SATA, but at least we
can avoid making it worse.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2008-04-14 14:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 17:10 [PATCH 2/2] [POWERPC] UCC nodes cleanup Anton Vorontsov
2008-04-11 14:13 ` Kumar Gala
2008-04-11 14:26   ` Timur Tabi
2008-04-11 16:06   ` Anton Vorontsov
2008-04-11 16:06     ` Anton Vorontsov
2008-04-11 16:48     ` Timur Tabi
2008-04-11 17:06       ` Anton Vorontsov
2008-04-11 17:06         ` Anton Vorontsov
2008-04-11 17:08         ` Timur Tabi
2008-04-11 17:08           ` Timur Tabi
2008-04-11 17:11         ` Anton Vorontsov
2008-04-11 17:11           ` Anton Vorontsov
2008-04-11 17:12           ` Timur Tabi
2008-04-11 17:21             ` Anton Vorontsov
2008-04-11 17:21               ` Anton Vorontsov
2008-04-11 17:31               ` Anton Vorontsov
2008-04-14 14:51                 ` Kumar Gala
2008-04-14 14:56                   ` Timur Tabi [this message]
2008-04-14 14:58                     ` Kumar Gala
2008-04-14 14:58                       ` Kumar Gala
2008-04-14 15:04         ` Grant Likely
2008-04-14 15:04           ` Grant Likely
2008-04-11 17:08     ` Timur Tabi
2008-04-11 17:08       ` Timur Tabi
2008-04-14 14:59     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4803708B.1070009@freescale.com \
    --to=timur@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.