From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup
Date: Fri, 11 Apr 2008 21:06:57 +0400 [thread overview]
Message-ID: <20080411170657.GA15270@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <47FF9665.7020403@freescale.com>
On Fri, Apr 11, 2008 at 11:48:37AM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> > On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote:
> >> On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote:
> >>> - get rid of `model = "UCC"' in the ucc nodes
> >>> It isn't used anywhere, so remove it. If we'll ever need something
> >>> like this, we'll use compatible property instead.
> >>> - replace cell-index and device-id properties by fsl,ucc.
> >>>
> >>> Drivers are modified for backward compatibility's sake.
> >> I'd prefer we use cell-index and not introduce "fsl,ucc". I'm ok with
> >> dropping device-id and model (its implied in the compatiable).
> >
> > Ok. Here it is. netdev and linux-serial Cc'ed.
>
> Do we want the first UCC to have a cell-index of 1? Maybe we should fix this
> off-by-one error once and for all, and number all UCCs from 0?
Isn't documentation numbers UCC from 1? Then I believe we should stick
with it for device tree, since off by one is Linux implementation details.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup
Date: Fri, 11 Apr 2008 21:06:57 +0400 [thread overview]
Message-ID: <20080411170657.GA15270@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <47FF9665.7020403@freescale.com>
On Fri, Apr 11, 2008 at 11:48:37AM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> > On Fri, Apr 11, 2008 at 09:13:36AM -0500, Kumar Gala wrote:
> >> On Mar 11, 2008, at 12:10 PM, Anton Vorontsov wrote:
> >>> - get rid of `model = "UCC"' in the ucc nodes
> >>> It isn't used anywhere, so remove it. If we'll ever need something
> >>> like this, we'll use compatible property instead.
> >>> - replace cell-index and device-id properties by fsl,ucc.
> >>>
> >>> Drivers are modified for backward compatibility's sake.
> >> I'd prefer we use cell-index and not introduce "fsl,ucc". I'm ok with
> >> dropping device-id and model (its implied in the compatiable).
> >
> > Ok. Here it is. netdev and linux-serial Cc'ed.
>
> Do we want the first UCC to have a cell-index of 1? Maybe we should fix this
> off-by-one error once and for all, and number all UCCs from 0?
Isn't documentation numbers UCC from 1? Then I believe we should stick
with it for device tree, since off by one is Linux implementation details.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-04-11 17:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 17:10 [PATCH 2/2] [POWERPC] UCC nodes cleanup Anton Vorontsov
2008-04-11 14:13 ` Kumar Gala
2008-04-11 14:26 ` Timur Tabi
2008-04-11 16:06 ` Anton Vorontsov
2008-04-11 16:06 ` Anton Vorontsov
2008-04-11 16:48 ` Timur Tabi
2008-04-11 17:06 ` Anton Vorontsov [this message]
2008-04-11 17:06 ` Anton Vorontsov
2008-04-11 17:08 ` Timur Tabi
2008-04-11 17:08 ` Timur Tabi
2008-04-11 17:11 ` Anton Vorontsov
2008-04-11 17:11 ` Anton Vorontsov
2008-04-11 17:12 ` Timur Tabi
2008-04-11 17:21 ` Anton Vorontsov
2008-04-11 17:21 ` Anton Vorontsov
2008-04-11 17:31 ` Anton Vorontsov
2008-04-14 14:51 ` Kumar Gala
2008-04-14 14:56 ` Timur Tabi
2008-04-14 14:58 ` Kumar Gala
2008-04-14 14:58 ` Kumar Gala
2008-04-14 15:04 ` Grant Likely
2008-04-14 15:04 ` Grant Likely
2008-04-11 17:08 ` Timur Tabi
2008-04-11 17:08 ` Timur Tabi
2008-04-14 14:59 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411170657.GA15270@polina.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.