All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
	linuxppc-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
	linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup
Date: Fri, 11 Apr 2008 21:21:06 +0400	[thread overview]
Message-ID: <20080411172106.GA17786@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <47FF9BFE.5000201@freescale.com>

On Fri, Apr 11, 2008 at 12:12:30PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> > Or maybe I'm thinking here in terms of "fsl,ucc"... and cell-index is
> > indeed should be -1... don't know. Please decide. ;-)
> 
> Well, that's what I was thinking.  cell-index is zero-based, so UCC1 should have
> cell-index = <0>.
> 
> Of course, this means all the code needs to change, since I think device-id is
> one-based.

Yup. You raised a really good question, because we're _introducing_
cell-index for UCC nodes, and if we'll choice wrong numbering scheme
now, then there will be no way back w/o breaking backward compatibility.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Jeff Garzik <jgarzik@pobox.com>,
	linux-serial@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup
Date: Fri, 11 Apr 2008 21:21:06 +0400	[thread overview]
Message-ID: <20080411172106.GA17786@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <47FF9BFE.5000201@freescale.com>

On Fri, Apr 11, 2008 at 12:12:30PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> > Or maybe I'm thinking here in terms of "fsl,ucc"... and cell-index is
> > indeed should be -1... don't know. Please decide. ;-)
> 
> Well, that's what I was thinking.  cell-index is zero-based, so UCC1 should have
> cell-index = <0>.
> 
> Of course, this means all the code needs to change, since I think device-id is
> one-based.

Yup. You raised a really good question, because we're _introducing_
cell-index for UCC nodes, and if we'll choice wrong numbering scheme
now, then there will be no way back w/o breaking backward compatibility.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2008-04-11 17:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 17:10 [PATCH 2/2] [POWERPC] UCC nodes cleanup Anton Vorontsov
2008-04-11 14:13 ` Kumar Gala
2008-04-11 14:26   ` Timur Tabi
2008-04-11 16:06   ` Anton Vorontsov
2008-04-11 16:06     ` Anton Vorontsov
2008-04-11 16:48     ` Timur Tabi
2008-04-11 17:06       ` Anton Vorontsov
2008-04-11 17:06         ` Anton Vorontsov
2008-04-11 17:08         ` Timur Tabi
2008-04-11 17:08           ` Timur Tabi
2008-04-11 17:11         ` Anton Vorontsov
2008-04-11 17:11           ` Anton Vorontsov
2008-04-11 17:12           ` Timur Tabi
2008-04-11 17:21             ` Anton Vorontsov [this message]
2008-04-11 17:21               ` Anton Vorontsov
2008-04-11 17:31               ` Anton Vorontsov
2008-04-14 14:51                 ` Kumar Gala
2008-04-14 14:56                   ` Timur Tabi
2008-04-14 14:58                     ` Kumar Gala
2008-04-14 14:58                       ` Kumar Gala
2008-04-14 15:04         ` Grant Likely
2008-04-14 15:04           ` Grant Likely
2008-04-11 17:08     ` Timur Tabi
2008-04-11 17:08       ` Timur Tabi
2008-04-14 14:59     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080411172106.GA17786@polina.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.