From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, skumar@linux.vnet.ibm.com,
yamamoto@valinux.co.jp, menage@google.com, lizf@cn.fujitsu.com,
linux-kernel@vger.kernel.org, rientjes@google.com,
xemul@openvz.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [-mm][PATCH 1/4] Setup the rlimit controller
Date: Tue, 06 May 2008 09:10:50 +0530 [thread overview]
Message-ID: <481FD342.2040707@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080505151142.f52b9d9e.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Sun, 04 May 2008 03:07:36 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> + *tmp = ((*tmp + PAGE_SIZE) >> PAGE_SHIFT) << PAGE_SHIFT;
>
> Whatever this is doing, it should not be doing it this way ;)
>
> perhaps
>
> *tmp = ALIGN(*tmp, PAGE_SIZE);
>
> or even
>
> *tmp = PAGE_ALIGN(*tmp);
>
> ?
>
Good point, thanks for catching this.
>
> <looks at PAGE_ALIGN>
>
> Each architecture implements its own version and they of course do it
> differently. It's crying out for a consolidated implementation but we have
> no include/linux/page.h into which to consolidate it.
May be we can move this to asm-generic/page.h?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, skumar@linux.vnet.ibm.com,
yamamoto@valinux.co.jp, menage@google.com, lizf@cn.fujitsu.com,
linux-kernel@vger.kernel.org, rientjes@google.com,
xemul@openvz.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [-mm][PATCH 1/4] Setup the rlimit controller
Date: Tue, 06 May 2008 09:10:50 +0530 [thread overview]
Message-ID: <481FD342.2040707@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080505151142.f52b9d9e.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Sun, 04 May 2008 03:07:36 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> + *tmp = ((*tmp + PAGE_SIZE) >> PAGE_SHIFT) << PAGE_SHIFT;
>
> Whatever this is doing, it should not be doing it this way ;)
>
> perhaps
>
> *tmp = ALIGN(*tmp, PAGE_SIZE);
>
> or even
>
> *tmp = PAGE_ALIGN(*tmp);
>
> ?
>
Good point, thanks for catching this.
>
> <looks at PAGE_ALIGN>
>
> Each architecture implements its own version and they of course do it
> differently. It's crying out for a consolidated implementation but we have
> no include/linux/page.h into which to consolidate it.
May be we can move this to asm-generic/page.h?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-06 3:41 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 21:37 [-mm][PATCH 0/4] Add rlimit controller to cgroups (v3) Balbir Singh
2008-05-03 21:37 ` Balbir Singh
2008-05-03 21:37 ` [-mm][PATCH 1/4] Setup the rlimit controller Balbir Singh
2008-05-03 21:37 ` Balbir Singh
2008-05-05 22:11 ` Andrew Morton
2008-05-05 22:11 ` Andrew Morton
2008-05-06 3:40 ` Balbir Singh [this message]
2008-05-06 3:40 ` Balbir Singh
2008-05-06 1:31 ` Li Zefan
2008-05-06 1:31 ` Li Zefan
2008-05-06 8:15 ` Balbir Singh
2008-05-06 8:15 ` Balbir Singh
2008-05-03 21:38 ` [-mm][PATCH 2/4] Enhance cgroup mm_owner_changed callback to add task information Balbir Singh
2008-05-03 21:38 ` Balbir Singh
2008-05-05 22:15 ` Andrew Morton
2008-05-05 22:15 ` Andrew Morton
2008-05-06 3:43 ` Balbir Singh
2008-05-06 3:43 ` Balbir Singh
2008-05-05 23:00 ` Paul Menage
2008-05-05 23:00 ` Paul Menage
2008-05-03 21:38 ` [-mm][PATCH 3/4] Add rlimit controller accounting and control Balbir Singh
2008-05-03 21:38 ` Balbir Singh
2008-05-05 22:24 ` Andrew Morton
2008-05-05 22:24 ` Andrew Morton
2008-05-05 22:32 ` David Rientjes
2008-05-05 22:32 ` David Rientjes
2008-05-06 5:34 ` Balbir Singh
2008-05-06 5:34 ` Balbir Singh
2008-05-07 3:17 ` Paul Menage
2008-05-07 3:17 ` Paul Menage
2008-05-07 5:59 ` Pavel Emelyanov
2008-05-07 5:59 ` Pavel Emelyanov
2008-05-08 14:54 ` Balbir Singh
2008-05-08 14:54 ` Balbir Singh
2008-05-08 23:22 ` Paul Menage
2008-05-08 23:22 ` Paul Menage
2008-05-07 3:29 ` Paul Menage
2008-05-07 3:29 ` Paul Menage
2008-05-08 14:35 ` Balbir Singh
2008-05-08 14:35 ` Balbir Singh
2008-05-08 21:45 ` Paul Menage
2008-05-08 21:45 ` Paul Menage
2008-05-09 13:35 ` Balbir Singh
2008-05-09 13:35 ` Balbir Singh
2008-05-03 21:38 ` [-mm][PATCH 4/4] Add rlimit controller documentation Balbir Singh
2008-05-03 21:38 ` Balbir Singh
2008-05-05 22:35 ` Andrew Morton
2008-05-05 22:35 ` Andrew Morton
2008-05-06 5:39 ` Balbir Singh
2008-05-06 5:39 ` Balbir Singh
2008-05-06 5:54 ` Andrew Morton
2008-05-06 5:54 ` Andrew Morton
2008-05-06 7:59 ` Balbir Singh
2008-05-06 7:59 ` Balbir Singh
2008-05-04 15:24 ` [-mm][PATCH 0/4] Add rlimit controller to cgroups (v3) kamezawa.hiroyu
2008-05-04 15:24 ` kamezawa.hiroyu
2008-05-04 15:27 ` kamezawa.hiroyu
2008-05-04 15:27 ` kamezawa.hiroyu
2008-05-05 4:24 ` Balbir Singh
2008-05-05 4:24 ` Balbir Singh
2008-05-05 4:21 ` Balbir Singh
2008-05-05 4:21 ` Balbir Singh
2008-05-07 1:09 ` KAMEZAWA Hiroyuki
2008-05-07 1:09 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481FD342.2040707@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.