* [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-02 19:09 ` Brian Mayer
0 siblings, 0 replies; 10+ messages in thread
From: Brian Mayer @ 2026-07-02 19:09 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Hi kernel team.
I was testing building the kernel for my radxa cm5+io shield, and it turns
out there is no rtc in the DTS, so I got it from the radxa files.
This is my first email to you, please help me correct it if something is
off the standards.
The commit attached does the trick. I used AI to assist me in this in
case you're
wondering.
Best, Brian
[-- Attachment #2: 0001-arm64-dts-rockchip-add-HYM8563-RTC-to-Radxa-CM5-IO-b.patch --]
[-- Type: application/octet-stream, Size: 1999 bytes --]
From 8841981021b5f98522ad44fe40e11d0c0e756534 Mon Sep 17 00:00:00 2001
From: Brian Mayer <bleemayer@gmail.com>
Date: Thu, 2 Jul 2026 14:51:51 -0300
Subject: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
battery holder. Without a device tree node, no /dev/rtc* appears even
when CONFIG_RTC_DRV_HYM8563 is enabled.
Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
the external clock. Wiring matches Radxa's downstream board support.
Signed-off-by: Brian Mayer <bleemayer@gmail.com>
Tested-by: Brian Mayer <bleemayer@gmail.com>
---
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
index af4a9bc01..1a2c72831 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -19,6 +19,7 @@ / {
aliases {
ethernet0 = &gmac1;
mmc1 = &sdmmc;
+ rtc0 = &hym8563;
};
chosen {
@@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
};
};
};
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtc_int>;
+ wakeup-source;
+ };
};
&i2s5_8ch {
@@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
};
};
+ hym8563 {
+ rtc_int: rtc-int {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
hdmi {
hdmi0_tx_on_h: hdmi0-tx-on-h {
rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
--
2.54.0
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-02 19:09 ` Brian Mayer
0 siblings, 0 replies; 10+ messages in thread
From: Brian Mayer @ 2026-07-02 19:09 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Hi kernel team.
I was testing building the kernel for my radxa cm5+io shield, and it turns
out there is no rtc in the DTS, so I got it from the radxa files.
This is my first email to you, please help me correct it if something is
off the standards.
The commit attached does the trick. I used AI to assist me in this in
case you're
wondering.
Best, Brian
[-- Attachment #2: 0001-arm64-dts-rockchip-add-HYM8563-RTC-to-Radxa-CM5-IO-b.patch --]
[-- Type: application/octet-stream, Size: 1999 bytes --]
From 8841981021b5f98522ad44fe40e11d0c0e756534 Mon Sep 17 00:00:00 2001
From: Brian Mayer <bleemayer@gmail.com>
Date: Thu, 2 Jul 2026 14:51:51 -0300
Subject: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
battery holder. Without a device tree node, no /dev/rtc* appears even
when CONFIG_RTC_DRV_HYM8563 is enabled.
Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
the external clock. Wiring matches Radxa's downstream board support.
Signed-off-by: Brian Mayer <bleemayer@gmail.com>
Tested-by: Brian Mayer <bleemayer@gmail.com>
---
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
index af4a9bc01..1a2c72831 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -19,6 +19,7 @@ / {
aliases {
ethernet0 = &gmac1;
mmc1 = &sdmmc;
+ rtc0 = &hym8563;
};
chosen {
@@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
};
};
};
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtc_int>;
+ wakeup-source;
+ };
};
&i2s5_8ch {
@@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
};
};
+ hym8563 {
+ rtc_int: rtc-int {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
hdmi {
hdmi0_tx_on_h: hdmi0-tx-on-h {
rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
2026-07-02 19:09 ` Brian Mayer
@ 2026-07-03 16:12 ` Heiko Stübner
-1 siblings, 0 replies; 10+ messages in thread
From: Heiko Stübner @ 2026-07-03 16:12 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Brian Mayer
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Hi Brian,
Am Donnerstag, 2. Juli 2026, 21:09:20 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hi kernel team.
>
> I was testing building the kernel for my radxa cm5+io shield, and it turns
> out there is no rtc in the DTS, so I got it from the radxa files.
> This is my first email to you, please help me correct it if something is
> off the standards.
>
> The commit attached does the trick. I used AI to assist me in this in
> case you're
> wondering.
Generally, please don't post patches as attachments.
For review comments it es expected to be able to comment
inline in the patch.
Ideally use git-send-email or b4 for sending patches.
For AI assisted changes, there is an Assisted-by: tag [0]
Please drop the Tested-by tag ... as you're sending in the patch and
your signed-off-by is on it, it is expected that you tested that change :-) .
Patch contents:
Please use names found in the schematics ... the pin is named
rtc_int_l there ... so the pinctrl entry should be "rtc_int_l: rtc-int-l { "...
This allows easier lookups when going from DT to schematics and back.
Thanks
Heiko
[0] https://docs.kernel.org/process/coding-assistants.html
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-03 16:12 ` Heiko Stübner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stübner @ 2026-07-03 16:12 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Brian Mayer
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Hi Brian,
Am Donnerstag, 2. Juli 2026, 21:09:20 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hi kernel team.
>
> I was testing building the kernel for my radxa cm5+io shield, and it turns
> out there is no rtc in the DTS, so I got it from the radxa files.
> This is my first email to you, please help me correct it if something is
> off the standards.
>
> The commit attached does the trick. I used AI to assist me in this in
> case you're
> wondering.
Generally, please don't post patches as attachments.
For review comments it es expected to be able to comment
inline in the patch.
Ideally use git-send-email or b4 for sending patches.
For AI assisted changes, there is an Assisted-by: tag [0]
Please drop the Tested-by tag ... as you're sending in the patch and
your signed-off-by is on it, it is expected that you tested that change :-) .
Patch contents:
Please use names found in the schematics ... the pin is named
rtc_int_l there ... so the pinctrl entry should be "rtc_int_l: rtc-int-l { "...
This allows easier lookups when going from DT to schematics and back.
Thanks
Heiko
[0] https://docs.kernel.org/process/coding-assistants.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
2026-07-03 16:12 ` Heiko Stübner
@ 2026-07-05 18:19 ` Brian Mayer
-1 siblings, 0 replies; 10+ messages in thread
From: Brian Mayer @ 2026-07-05 18:19 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, devicetree, linux-arm-kernel
Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since
this v2 only contains name changes I didn't test. I added the missing
agent tag and am sending the patch inline. Thanks.
The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
battery holder. Without a device tree node, no /dev/rtc* appears even
when CONFIG_RTC_DRV_HYM8563 is enabled.
Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
the external clock. Wiring matches Radxa's downstream board support and
uses schematic names for the rtc_int_l pinctrl entry.
Assisted-by: Grok:grok-build
Signed-off-by: Brian Mayer <bleemayer@gmail.com>
---
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
Changes in v2:
- Rename pinctrl to rtc_int_l / rtc-int-l to match schematics
- Drop Tested-by (covered by Signed-off-by)
- Add Assisted-by: Grok:grok-build
- Send inline with git send-email (not as attachment)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
index af4a9bc01..d22db4d18 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -19,6 +19,7 @@ / {
aliases {
ethernet0 = &gmac1;
mmc1 = &sdmmc;
+ rtc0 = &hym8563;
};
chosen {
@@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
};
};
};
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtc_int_l>;
+ wakeup-source;
+ };
};
&i2s5_8ch {
@@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
};
};
+ hym8563 {
+ rtc_int_l: rtc-int-l {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
hdmi {
hdmi0_tx_on_h: hdmi0-tx-on-h {
rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-05 18:19 ` Brian Mayer
0 siblings, 0 replies; 10+ messages in thread
From: Brian Mayer @ 2026-07-05 18:19 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, devicetree, linux-arm-kernel
Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since
this v2 only contains name changes I didn't test. I added the missing
agent tag and am sending the patch inline. Thanks.
The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
battery holder. Without a device tree node, no /dev/rtc* appears even
when CONFIG_RTC_DRV_HYM8563 is enabled.
Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
the external clock. Wiring matches Radxa's downstream board support and
uses schematic names for the rtc_int_l pinctrl entry.
Assisted-by: Grok:grok-build
Signed-off-by: Brian Mayer <bleemayer@gmail.com>
---
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
Changes in v2:
- Rename pinctrl to rtc_int_l / rtc-int-l to match schematics
- Drop Tested-by (covered by Signed-off-by)
- Add Assisted-by: Grok:grok-build
- Send inline with git send-email (not as attachment)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
index af4a9bc01..d22db4d18 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -19,6 +19,7 @@ / {
aliases {
ethernet0 = &gmac1;
mmc1 = &sdmmc;
+ rtc0 = &hym8563;
};
chosen {
@@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
};
};
};
+
+ hym8563: rtc@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-output-names = "hym8563";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rtc_int_l>;
+ wakeup-source;
+ };
};
&i2s5_8ch {
@@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
};
};
+ hym8563 {
+ rtc_int_l: rtc-int-l {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
hdmi {
hdmi0_tx_on_h: hdmi0-tx-on-h {
rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
--
2.54.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
2026-07-05 18:19 ` Brian Mayer
@ 2026-07-07 19:02 ` Heiko Stuebner
-1 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2026-07-07 19:02 UTC (permalink / raw)
To: Brian Mayer; +Cc: linux-rockchip, devicetree, linux-arm-kernel
Hi Brian,
I've applied the change with some changes.
Please the comments below in mind for future patches, but there is no
need to send another version:
Am Sonntag, 5. Juli 2026, 20:19:19 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since
> this v2 only contains name changes I didn't test. I added the missing
> agent tag and am sending the patch inline. Thanks.
>
> The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
> address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
> battery holder. Without a device tree node, no /dev/rtc* appears even
> when CONFIG_RTC_DRV_HYM8563 is enabled.
>
> Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
> wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
> the external clock. Wiring matches Radxa's downstream board support and
> uses schematic names for the rtc_int_l pinctrl entry.
Please way less AI fluff. The patch content show that you're wiring up the
interrupt + pinctrl etc.
Also, please no personal "Hello again ...." in the actual commit message.
The text above is the text that ends up in the git log for your change,
so should be short and to the point.
I've shortened it to:
-----
Describe the Haoyu HYM8563 RTC connected to I2C6 on the Radxa CM5 IO
carrier including its interrupt line.
-----
> Assisted-by: Grok:grok-build
> Signed-off-by: Brian Mayer <bleemayer@gmail.com>
> ---
Personal comments, remarks etc should be here, below the 3 dashes and
above the diffstat. That way we can still read them, but they don't
end up in the git history.
> .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> Changes in v2:
> - Rename pinctrl to rtc_int_l / rtc-int-l to match schematics
> - Drop Tested-by (covered by Signed-off-by)
> - Add Assisted-by: Grok:grok-build
> - Send inline with git send-email (not as attachment)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> index af4a9bc01..d22db4d18 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> @@ -19,6 +19,7 @@ / {
> aliases {
> ethernet0 = &gmac1;
> mmc1 = &sdmmc;
> + rtc0 = &hym8563;
> };
>
> chosen {
> @@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
> };
> };
> };
> +
> + hym8563: rtc@51 {
> + compatible = "haoyu,hym8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + clock-output-names = "hym8563";
> + interrupt-parent = <&gpio0>;
> + interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&rtc_int_l>;
> + wakeup-source;
> + };
> };
>
> &i2s5_8ch {
> @@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
> };
> };
>
> + hym8563 {
> + rtc_int_l: rtc-int-l {
> + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> +
please sort nodes alphabetically (hdmi -> hym8563)
I did that when applying.
Thanks
Heiko
> hdmi {
> hdmi0_tx_on_h: hdmi0-tx-on-h {
> rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
>
> base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-07 19:02 ` Heiko Stuebner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2026-07-07 19:02 UTC (permalink / raw)
To: Brian Mayer; +Cc: linux-rockchip, devicetree, linux-arm-kernel
Hi Brian,
I've applied the change with some changes.
Please the comments below in mind for future patches, but there is no
need to send another version:
Am Sonntag, 5. Juli 2026, 20:19:19 Mitteleuropäische Sommerzeit schrieb Brian Mayer:
> Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since
> this v2 only contains name changes I didn't test. I added the missing
> agent tag and am sending the patch inline. Thanks.
>
> The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
> address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
> battery holder. Without a device tree node, no /dev/rtc* appears even
> when CONFIG_RTC_DRV_HYM8563 is enabled.
>
> Describe the RTC, wire the interrupt pin with a pull-up, mark it as a
> wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use
> the external clock. Wiring matches Radxa's downstream board support and
> uses schematic names for the rtc_int_l pinctrl entry.
Please way less AI fluff. The patch content show that you're wiring up the
interrupt + pinctrl etc.
Also, please no personal "Hello again ...." in the actual commit message.
The text above is the text that ends up in the git log for your change,
so should be short and to the point.
I've shortened it to:
-----
Describe the Haoyu HYM8563 RTC connected to I2C6 on the Radxa CM5 IO
carrier including its interrupt line.
-----
> Assisted-by: Grok:grok-build
> Signed-off-by: Brian Mayer <bleemayer@gmail.com>
> ---
Personal comments, remarks etc should be here, below the 3 dashes and
above the diffstat. That way we can still read them, but they don't
end up in the git history.
> .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> Changes in v2:
> - Rename pinctrl to rtc_int_l / rtc-int-l to match schematics
> - Drop Tested-by (covered by Signed-off-by)
> - Add Assisted-by: Grok:grok-build
> - Send inline with git send-email (not as attachment)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> index af4a9bc01..d22db4d18 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
> @@ -19,6 +19,7 @@ / {
> aliases {
> ethernet0 = &gmac1;
> mmc1 = &sdmmc;
> + rtc0 = &hym8563;
> };
>
> chosen {
> @@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint {
> };
> };
> };
> +
> + hym8563: rtc@51 {
> + compatible = "haoyu,hym8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + clock-output-names = "hym8563";
> + interrupt-parent = <&gpio0>;
> + interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&rtc_int_l>;
> + wakeup-source;
> + };
> };
>
> &i2s5_8ch {
> @@ -221,6 +234,12 @@ usbc0_int: usbc0-int {
> };
> };
>
> + hym8563 {
> + rtc_int_l: rtc-int-l {
> + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> +
please sort nodes alphabetically (hdmi -> hym8563)
I did that when applying.
Thanks
Heiko
> hdmi {
> hdmi0_tx_on_h: hdmi0-tx-on-h {
> rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
>
> base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
2026-07-05 18:19 ` Brian Mayer
@ 2026-07-07 19:44 ` Heiko Stuebner
-1 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2026-07-07 19:44 UTC (permalink / raw)
To: Brian Mayer; +Cc: Heiko Stuebner, linux-rockchip, devicetree, linux-arm-kernel
On Sun, 05 Jul 2026 15:19:19 -0300, Brian Mayer wrote:
> this v2 only contains name changes I didn't test. I added the missing
> agent tag and am sending the patch inline. Thanks.
>
> The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
> address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
> battery holder. Without a device tree node, no /dev/rtc* appears even
> when CONFIG_RTC_DRV_HYM8563 is enabled.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
commit: 1945f419277503ebacd87cc221e370c8b6b94a7d
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
@ 2026-07-07 19:44 ` Heiko Stuebner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2026-07-07 19:44 UTC (permalink / raw)
To: Brian Mayer; +Cc: Heiko Stuebner, linux-rockchip, devicetree, linux-arm-kernel
On Sun, 05 Jul 2026 15:19:19 -0300, Brian Mayer wrote:
> this v2 only contains name changes I didn't test. I added the missing
> agent tag and am sending the patch inline. Thanks.
>
> The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at
> address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup
> battery holder. Without a device tree node, no /dev/rtc* appears even
> when CONFIG_RTC_DRV_HYM8563 is enabled.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board
commit: 1945f419277503ebacd87cc221e370c8b6b94a7d
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-07-07 19:44 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-02 19:09 [PATCH] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Brian Mayer
2026-07-02 19:09 ` Brian Mayer
2026-07-03 16:12 ` Heiko Stübner
2026-07-03 16:12 ` Heiko Stübner
2026-07-05 18:19 ` [PATCH v2] " Brian Mayer
2026-07-05 18:19 ` Brian Mayer
2026-07-07 19:02 ` Heiko Stuebner
2026-07-07 19:02 ` Heiko Stuebner
2026-07-07 19:44 ` Heiko Stuebner
2026-07-07 19:44 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.