From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Matt Mackall <mpm@selenic.com>
Cc: MinChan Kim <minchan.kim@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] Fix to return wrong pointer in slob
Date: Mon, 19 May 2008 20:55:24 +0300 [thread overview]
Message-ID: <4831BF0C.4010905@cs.helsinki.fi> (raw)
In-Reply-To: <1211218837.18026.116.camel@calx>
Matt Mackall wrote:
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
>
> Otherwise,
>
> Acked-by: Matt Mackall <mpm@selenic.com>
>
> [cc:ed to Pekka, who manages the allocator tree]
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Matt Mackall <mpm@selenic.com>
Cc: MinChan Kim <minchan.kim@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] Fix to return wrong pointer in slob
Date: Mon, 19 May 2008 20:55:24 +0300 [thread overview]
Message-ID: <4831BF0C.4010905@cs.helsinki.fi> (raw)
In-Reply-To: <1211218837.18026.116.camel@calx>
Matt Mackall wrote:
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
>
> Otherwise,
>
> Acked-by: Matt Mackall <mpm@selenic.com>
>
> [cc:ed to Pekka, who manages the allocator tree]
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-19 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 13:12 [PATCH] Fix to return wrong pointer in slob MinChan Kim
2008-05-19 13:12 ` MinChan Kim
2008-05-19 17:40 ` Matt Mackall
2008-05-19 17:40 ` Matt Mackall
2008-05-19 17:55 ` Pekka Enberg [this message]
2008-05-19 17:55 ` Pekka Enberg
2008-05-20 2:32 ` MinChan Kim
2008-05-20 2:32 ` MinChan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831BF0C.4010905@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.