* Re: [PATCH] Fix to return wrong pointer in slob
@ 2008-05-19 17:40 ` Matt Mackall
0 siblings, 0 replies; 8+ messages in thread
From: Matt Mackall @ 2008-05-19 17:40 UTC (permalink / raw)
To: MinChan Kim; +Cc: linux-kernel, Andrew Morton, linux-mm, Pekka J Enberg
On Mon, 2008-05-19 at 22:12 +0900, MinChan Kim wrote:
> Although slob_alloc return NULL, __kmalloc_node returns NULL + align.
> Because align always can be changed, it is very hard for debugging
> problem of no page if it don't return NULL.
>
> We have to return NULL in case of no page.
>
> Signed-off-by: MinChan Kim <minchan.kim@gmail.com>
> ---
> mm/slob.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/mm/slob.c b/mm/slob.c
> index 6038cba..258d76d 100644
> --- a/mm/slob.c
> +++ b/mm/slob.c
> @@ -469,9 +469,12 @@ void *__kmalloc_node(size_t size, gfp_t gfp, int node)
> return ZERO_SIZE_PTR;
>
> m = slob_alloc(size + align, gfp, align, node);
> - if (m)
> - *m = size;
> - return (void *)m + align;
> + if (!m)
> + return NULL;
> + else {
> + *m = size;
> + return (void *)m + align;
> + }
This looks good, but I would remove the 'else {' and '}' here. It's nice
to have the 'normal path' minimally indented.
Otherwise,
Acked-by: Matt Mackall <mpm@selenic.com>
[cc:ed to Pekka, who manages the allocator tree]
> } else {
> void *ret;
>
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Fix to return wrong pointer in slob
2008-05-19 17:40 ` Matt Mackall
@ 2008-05-19 17:55 ` Pekka Enberg
-1 siblings, 0 replies; 8+ messages in thread
From: Pekka Enberg @ 2008-05-19 17:55 UTC (permalink / raw)
To: Matt Mackall; +Cc: MinChan Kim, linux-kernel, Andrew Morton, linux-mm
Matt Mackall wrote:
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
>
> Otherwise,
>
> Acked-by: Matt Mackall <mpm@selenic.com>
>
> [cc:ed to Pekka, who manages the allocator tree]
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Fix to return wrong pointer in slob
@ 2008-05-19 17:55 ` Pekka Enberg
0 siblings, 0 replies; 8+ messages in thread
From: Pekka Enberg @ 2008-05-19 17:55 UTC (permalink / raw)
To: Matt Mackall; +Cc: MinChan Kim, linux-kernel, Andrew Morton, linux-mm
Matt Mackall wrote:
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
>
> Otherwise,
>
> Acked-by: Matt Mackall <mpm@selenic.com>
>
> [cc:ed to Pekka, who manages the allocator tree]
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix to return wrong pointer in slob
2008-05-19 17:40 ` Matt Mackall
@ 2008-05-20 2:32 ` MinChan Kim
-1 siblings, 0 replies; 8+ messages in thread
From: MinChan Kim @ 2008-05-20 2:32 UTC (permalink / raw)
To: Matt Mackall
Cc: MinChan Kim, linux-kernel, Andrew Morton, linux-mm,
Pekka J Enberg
On Tue, May 20, 2008 at 2:40 AM, Matt Mackall <mpm@selenic.com> wrote:
>
> On Mon, 2008-05-19 at 22:12 +0900, MinChan Kim wrote:
>> Although slob_alloc return NULL, __kmalloc_node returns NULL + align.
>> Because align always can be changed, it is very hard for debugging
>> problem of no page if it don't return NULL.
>>
>> We have to return NULL in case of no page.
>>
>> Signed-off-by: MinChan Kim <minchan.kim@gmail.com>
>> ---
>> mm/slob.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/slob.c b/mm/slob.c
>> index 6038cba..258d76d 100644
>> --- a/mm/slob.c
>> +++ b/mm/slob.c
>> @@ -469,9 +469,12 @@ void *__kmalloc_node(size_t size, gfp_t gfp, int node)
>> return ZERO_SIZE_PTR;
>>
>> m = slob_alloc(size + align, gfp, align, node);
>> - if (m)
>> - *m = size;
>> - return (void *)m + align;
>> + if (!m)
>> + return NULL;
>> + else {
>> + *m = size;
>> + return (void *)m + align;
>> + }
>
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
I agree
Thanks, Matt :)
--
Thanks,
MinChan Kim
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Fix to return wrong pointer in slob
@ 2008-05-20 2:32 ` MinChan Kim
0 siblings, 0 replies; 8+ messages in thread
From: MinChan Kim @ 2008-05-20 2:32 UTC (permalink / raw)
To: Matt Mackall
Cc: MinChan Kim, linux-kernel, Andrew Morton, linux-mm,
Pekka J Enberg
On Tue, May 20, 2008 at 2:40 AM, Matt Mackall <mpm@selenic.com> wrote:
>
> On Mon, 2008-05-19 at 22:12 +0900, MinChan Kim wrote:
>> Although slob_alloc return NULL, __kmalloc_node returns NULL + align.
>> Because align always can be changed, it is very hard for debugging
>> problem of no page if it don't return NULL.
>>
>> We have to return NULL in case of no page.
>>
>> Signed-off-by: MinChan Kim <minchan.kim@gmail.com>
>> ---
>> mm/slob.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/slob.c b/mm/slob.c
>> index 6038cba..258d76d 100644
>> --- a/mm/slob.c
>> +++ b/mm/slob.c
>> @@ -469,9 +469,12 @@ void *__kmalloc_node(size_t size, gfp_t gfp, int node)
>> return ZERO_SIZE_PTR;
>>
>> m = slob_alloc(size + align, gfp, align, node);
>> - if (m)
>> - *m = size;
>> - return (void *)m + align;
>> + if (!m)
>> + return NULL;
>> + else {
>> + *m = size;
>> + return (void *)m + align;
>> + }
>
> This looks good, but I would remove the 'else {' and '}' here. It's nice
> to have the 'normal path' minimally indented.
I agree
Thanks, Matt :)
--
Thanks,
MinChan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread