All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Anderson <anderson@redhat.com>
To: "Discussion list for crash utility usage,
	maintenance and development" <crash-utility@redhat.com>
Cc: Itsuro ODA <oda@valinux.co.jp>,
	xen-devel@lists.xensource.com, kexec@lists.infradead.org
Subject: Re: [Crash-utility] Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note
Date: Fri, 30 May 2008 10:40:59 -0400	[thread overview]
Message-ID: <484011FB.6010604@redhat.com> (raw)
In-Reply-To: <C465CB32.2176B%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
>
>   
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>     
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
>  -- Keir
>   

Itsuro did it that way on purpose.  It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE.  crash doesn't know what a crash_xen_info_t structure is, but only
its old and new size.

Dave



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Dave Anderson <anderson@redhat.com>
To: "Discussion list for crash utility usage,
	maintenance and development" <crash-utility@redhat.com>
Cc: xen-devel@lists.xensource.com, kexec@lists.infradead.org
Subject: Re: Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note
Date: Fri, 30 May 2008 10:40:59 -0400	[thread overview]
Message-ID: <484011FB.6010604@redhat.com> (raw)
In-Reply-To: <C465CB32.2176B%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
>
>   
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>     
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
>  -- Keir
>   

Itsuro did it that way on purpose.  It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE.  crash doesn't know what a crash_xen_info_t structure is, but only
its old and new size.

Dave

  reply	other threads:[~2008-05-30 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30  5:13 [PATCH] Add xen_phys_start value in the crash info note Itsuro ODA
2008-05-30  5:13 ` Itsuro ODA
2008-05-30 14:18 ` [Xen-devel] " Keir Fraser
2008-05-30 14:18   ` Keir Fraser
2008-05-30 14:40   ` Dave Anderson [this message]
2008-05-30 14:40     ` Re: [Xen-devel] " Dave Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484011FB.6010604@redhat.com \
    --to=anderson@redhat.com \
    --cc=crash-utility@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=oda@valinux.co.jp \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.