* [PATCH] Add xen_phys_start value in the crash info note
@ 2008-05-30 5:13 ` Itsuro ODA
0 siblings, 0 replies; 6+ messages in thread
From: Itsuro ODA @ 2008-05-30 5:13 UTC (permalink / raw)
To: xen-devel; +Cc: kexec, crash-utility
Hi,
This patch makes the vmcore utilities (ex. crash, makedumpfile) be
able to get the relocation address of the xen hypervisor from a vmcore.
It is necessary for the utilities to find the data of the hypervisor
structures.
Note that this patch does not raise any comptibility issue for the
utilities (which I know) nor the other components of xen.
Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
diff -r f681c4de91fc xen/arch/x86/crash.c
--- a/xen/arch/x86/crash.c Wed May 28 16:14:10 2008 +0100
+++ b/xen/arch/x86/crash.c Fri May 30 08:40:50 2008 +0900
@@ -102,6 +102,7 @@ void machine_crash_shutdown(void)
hvm_cpu_down();
info = kexec_crash_save_info();
+ info->xen_phys_start = xen_phys_start;
info->dom0_pfn_to_mfn_frame_list_list =
arch_get_pfn_to_mfn_frame_list_list(dom0);
}
diff -r f681c4de91fc xen/include/xen/elfcore.h
--- a/xen/include/xen/elfcore.h Wed May 28 16:14:10 2008 +0100
+++ b/xen/include/xen/elfcore.h Fri May 30 08:39:40 2008 +0900
@@ -66,6 +66,7 @@ typedef struct {
unsigned long xen_compile_time;
unsigned long tainted;
#if defined(__i386__) || defined(__x86_64__)
+ unsigned long xen_phys_start;
unsigned long dom0_pfn_to_mfn_frame_list_list;
#endif
#if defined(__ia64__)
--
Itsuro ODA <oda@valinux.co.jp>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] Add xen_phys_start value in the crash info note
@ 2008-05-30 5:13 ` Itsuro ODA
0 siblings, 0 replies; 6+ messages in thread
From: Itsuro ODA @ 2008-05-30 5:13 UTC (permalink / raw)
To: xen-devel; +Cc: kexec, crash-utility
Hi,
This patch makes the vmcore utilities (ex. crash, makedumpfile) be
able to get the relocation address of the xen hypervisor from a vmcore.
It is necessary for the utilities to find the data of the hypervisor
structures.
Note that this patch does not raise any comptibility issue for the
utilities (which I know) nor the other components of xen.
Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
diff -r f681c4de91fc xen/arch/x86/crash.c
--- a/xen/arch/x86/crash.c Wed May 28 16:14:10 2008 +0100
+++ b/xen/arch/x86/crash.c Fri May 30 08:40:50 2008 +0900
@@ -102,6 +102,7 @@ void machine_crash_shutdown(void)
hvm_cpu_down();
info = kexec_crash_save_info();
+ info->xen_phys_start = xen_phys_start;
info->dom0_pfn_to_mfn_frame_list_list =
arch_get_pfn_to_mfn_frame_list_list(dom0);
}
diff -r f681c4de91fc xen/include/xen/elfcore.h
--- a/xen/include/xen/elfcore.h Wed May 28 16:14:10 2008 +0100
+++ b/xen/include/xen/elfcore.h Fri May 30 08:39:40 2008 +0900
@@ -66,6 +66,7 @@ typedef struct {
unsigned long xen_compile_time;
unsigned long tainted;
#if defined(__i386__) || defined(__x86_64__)
+ unsigned long xen_phys_start;
unsigned long dom0_pfn_to_mfn_frame_list_list;
#endif
#if defined(__ia64__)
--
Itsuro ODA <oda@valinux.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note
2008-05-30 5:13 ` Itsuro ODA
@ 2008-05-30 14:18 ` Keir Fraser
-1 siblings, 0 replies; 6+ messages in thread
From: Keir Fraser @ 2008-05-30 14:18 UTC (permalink / raw)
To: Itsuro ODA, xen-devel; +Cc: kexec, crash-utility
On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
> able to get the relocation address of the xen hypervisor from a vmcore.
> It is necessary for the utilities to find the data of the hypervisor
> structures.
>
> Note that this patch does not raise any comptibility issue for the
> utilities (which I know) nor the other components of xen.
Since it both changes the size of the crash_info elf note, and adds the new
field in the middle of the crash_info structure, how can it not affect
compatibility?
-- Keir
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add xen_phys_start value in the crash info note
@ 2008-05-30 14:18 ` Keir Fraser
0 siblings, 0 replies; 6+ messages in thread
From: Keir Fraser @ 2008-05-30 14:18 UTC (permalink / raw)
To: Itsuro ODA, xen-devel; +Cc: kexec, crash-utility
On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
> able to get the relocation address of the xen hypervisor from a vmcore.
> It is necessary for the utilities to find the data of the hypervisor
> structures.
>
> Note that this patch does not raise any comptibility issue for the
> utilities (which I know) nor the other components of xen.
Since it both changes the size of the crash_info elf note, and adds the new
field in the middle of the crash_info structure, how can it not affect
compatibility?
-- Keir
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Crash-utility] Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note
2008-05-30 14:18 ` Keir Fraser
@ 2008-05-30 14:40 ` Dave Anderson
-1 siblings, 0 replies; 6+ messages in thread
From: Dave Anderson @ 2008-05-30 14:40 UTC (permalink / raw)
To: Discussion list for crash utility usage, maintenance and development
Cc: Itsuro ODA, xen-devel, kexec
Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
>
>
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
> -- Keir
>
Itsuro did it that way on purpose. It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE. crash doesn't know what a crash_xen_info_t structure is, but only
its old and new size.
Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [Xen-devel] [PATCH] Add xen_phys_start value in the crash info note
@ 2008-05-30 14:40 ` Dave Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Dave Anderson @ 2008-05-30 14:40 UTC (permalink / raw)
To: Discussion list for crash utility usage, maintenance and development
Cc: xen-devel, kexec
Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
>
>
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
> -- Keir
>
Itsuro did it that way on purpose. It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE. crash doesn't know what a crash_xen_info_t structure is, but only
its old and new size.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-05-30 14:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 5:13 [PATCH] Add xen_phys_start value in the crash info note Itsuro ODA
2008-05-30 5:13 ` Itsuro ODA
2008-05-30 14:18 ` [Xen-devel] " Keir Fraser
2008-05-30 14:18 ` Keir Fraser
2008-05-30 14:40 ` [Crash-utility] Re: [Xen-devel] " Dave Anderson
2008-05-30 14:40 ` Dave Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.