Re: [PATCH] xend: open qemu-dm log files in append mode

[Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Ian Jackson wrote:
> Daniel P. Berrange writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode"):
>> XenD already does rotate the qemu logs unless the code I added todo 
>> that has since been removed, so if the domain reboots we should keep
>> at least one historic log
> 
> It only keeps one.  I think Yuji Shimada would like more than one but
> that would be a straightforward change to make to the code.
> 
> Ian.

So the attached patch improves the qemu-log rotation in xend to keep
maximum of 20 backup logfiles per domain. I still prefer the previous
patch that will avoid information loss when, for example, a guest
repeats cursh and reboot. But this patch might be at least a little bit
better than the current one-historic-backup solution. Any comment?

Thanks,
   Yosuke

[-- Attachment #2: qemu-log-rotate.patch --]
[-- Type: all/allfiles, Size: 1171 bytes --]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel