Re: [PATCH] xend: open qemu-dm log files in append mode

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Jun 26, 2008 at 03:47:43PM +0100, Ian Jackson wrote:
> Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] xend: open qemu-dm log files in append mode"):
> > qemu-dm log files would be easily overwritten if domains reboot several
> > times. With this patch, a single qemu-dm log file is used per domain and
> > log messages will be continuously appended to it.
> 
> Surely it would be better to rotate the logs rather than just
> appending.  Having each run in a separate file makes finding the
> relevant log entries much easier.

XenD already does rotate the qemu logs unless the code I added todo 
that has since been removed, so if the domain reboots we should keep
at least one historic log

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|