All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Yuji Shimada <shimada-yxb@necst.nec.co.jp>,
	xen-devel@lists.xensource.com, berrange@redhat.com
Subject: Re: [PATCH] xend: open qemu-dm log files in append mode
Date: Tue, 01 Jul 2008 13:57:35 +0900	[thread overview]
Message-ID: <4869B93F.8010502@ab.jp.nec.com> (raw)
In-Reply-To: <18536.58536.997240.887299@mariner.uk.xensource.com>

Ian Jackson wrote:
> Yosuke Iwamatsu writes ("Re: [Xen-devel] [PATCH] xend: open qemu-dm log files in append mode"):
>> Done in qemu-log-rotate-config.patch.
>> I've set the logrotate count default to 10. It is small enough not to
>> annoy users by filling xen log directory with many files, I think.
>>
>> I also created a patch (qemu-log-append-config.patch) which opens
>> qemu-dm logfiles in append mode if the logrotate count is 0. If this
>> makes sense, please apply it after qemu-log-rotate-config.patch.
> 
> That's great.  And, after a quick review, your patch looks sane to me.
> I assume you've tested both cases.

Year, tested and it looked working well.

> You forgot to add a Signed-Off-By.

Signed-off-bys are written inside the attachments themselves, but anyway
here is confirmation:

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>


--Yosuke

  reply	other threads:[~2008-07-01  4:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26  5:06 [PATCH] xend: open qemu-dm log files in append mode Yosuke Iwamatsu
2008-06-26 14:47 ` Ian Jackson
2008-06-26 14:51   ` Daniel P. Berrange
2008-06-26 15:04     ` Ian Jackson
2008-06-27  9:31       ` Yosuke Iwamatsu
2008-06-27 13:39         ` Ian Jackson
2008-06-30  9:20           ` Yosuke Iwamatsu
2008-06-30 13:50             ` Ian Jackson
2008-07-01  4:57               ` Yosuke Iwamatsu [this message]
2008-07-01  9:45                 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4869B93F.8010502@ab.jp.nec.com \
    --to=y-iwamatsu@ab.jp.nec.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=berrange@redhat.com \
    --cc=shimada-yxb@necst.nec.co.jp \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.