Re: [PATCH] xend: PV machines have no ioemu network

[Jeremy Fitzhardinge <jeremy@goop.org>]

Kevin Wolf wrote:
> Ians wants to keep changes from upstream qemu as small as possible in
> those files shared with qemu. I think this is the main reason why he
> didn't do it, and as long as slirp was compiled it just worked.
>
> Additionally, specifying no -net parameter always meant -net nic -net
> user for qemu, so we would not only change common code, but also the
> semantics of the command line parameters. I think this is even worse.
>   

If you've disabled slirp then "-net user" doesn't work; it would be 
pretty silly for qemu to default to using "-net user" if it can't 
possibly work.  I think my patch is a bugfix for base qemu.

> The right thing to do is to specify -net none from xend, IMHO.
>   

Yes, that makes sense anyway.

> Kevin
>
>
> xend: PV machines have no ioemu network
>
> In the command line parameters of qemu-dm, xend should specify -net none
> for PV machines. qemu-dm will assume -net nic -net user otherwise, which
> fails now because slirp is no longer compiled in.
>
> Signed-off-by: Kevin Wolf <kwolf@suse.de>
>   

    J