Re: [PATCH] xend: PV machines have no ioemu network

[Kevin Wolf <kwolf@suse.de>]

Jeremy Fitzhardinge schrieb:
> Kevin Wolf wrote:
>> Ians wants to keep changes from upstream qemu as small as possible in
>> those files shared with qemu. I think this is the main reason why he
>> didn't do it, and as long as slirp was compiled it just worked.
>>
>> Additionally, specifying no -net parameter always meant -net nic -net
>> user for qemu, so we would not only change common code, but also the
>> semantics of the command line parameters. I think this is even worse.
>>   
> 
> If you've disabled slirp then "-net user" doesn't work; it would be
> pretty silly for qemu to default to using "-net user" if it can't
> possibly work.  I think my patch is a bugfix for base qemu.

Agreed. If you submit it to upstream qemu, it's a proper fix.

Kevin