All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	Jean Guyader <jean.guyader@eu.citrix.com>
Subject: qemu-dm without slirp
Date: Mon, 14 Jul 2008 14:40:48 -0700	[thread overview]
Message-ID: <487BC7E0.9040106@goop.org> (raw)
In-Reply-To: <C4A0BAEA.1AF3A%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 13/7/08 07:27, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
>
>   
>> Jeremy Fitzhardinge wrote:
>>     
>>> but other stuff is failing... tapdisk?
>>>       
>> No, pvfb.  Hm.
>>     
>
> pvfb is built into qemu now?
>   

Ah.  I compiled qemu with --disable-gcc-check --disable-slirp as had 
been discussed on the list.  But that causes qemu-dm to fail with 
"Unknown network device: user", because it always  uses "user" (slirp) 
if you don't define any other net conifg.

I did this:

--- a/vl.c
+++ b/vl.c
@@ -8598,9 +8598,10 @@ int main(int argc, char **argv)
     /* init network clients */
     if (nb_net_clients == 0) {
         /* if no clients, we use a default config */
-        net_clients[0] = "nic";
-        net_clients[1] = "user";
-        nb_net_clients = 2;
+        net_clients[nb_net_clients++] = "nic";
+#ifdef CONFIG_SLIRP
+        net_clients[nb_net_clients++] = "user";
+#endif
     }
 
     for(i = 0;i < nb_net_clients; i++) {

to fix it.  The old qemu code put that whole default net configuration 
in #ifndef CONFIG_DM.  Ian, did you deliberately not do that in the new 
code, or is it an oversight?

    J

  parent reply	other threads:[~2008-07-14 21:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 11:13 [PATCH] cpuid configuration for PV guest Jean Guyader
2008-07-13  2:49 ` Jeremy Fitzhardinge
2008-07-13  6:00   ` Jeremy Fitzhardinge
2008-07-13  6:27     ` Jeremy Fitzhardinge
2008-07-14  7:12       ` Keir Fraser
2008-07-14  9:55         ` Samuel Thibault
2008-07-14 21:40         ` Jeremy Fitzhardinge [this message]
2008-07-15  8:58           ` [PATCH] xend: PV machines have no ioemu network Kevin Wolf
2008-07-15 15:01             ` Jeremy Fitzhardinge
2008-07-15 16:44               ` Kevin Wolf
2008-07-15 16:36           ` qemu-dm without slirp Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487BC7E0.9040106@goop.org \
    --to=jeremy@goop.org \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=jean.guyader@eu.citrix.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.