All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dougg@torque.net>
To: Christophe Varoqui <christophe.varoqui@free.fr>
Cc: linux-scsi@vger.kernel.org
Subject: Re: persistent reservation behaviour with dm-multipath
Date: Wed, 23 Jul 2008 16:28:57 -0400	[thread overview]
Message-ID: <48879489.6060401@torque.net> (raw)
In-Reply-To: <1216457992.7364.15.camel@plop>

Christophe Varoqui wrote:
> The current dm-multipath behaviour is currently a potent data corrupter
> on Persistant Reservation-based clusters sharing multipaths with the
> queue_if_no_path feature on (Clariion, Storageworks, ...).
> 
> Consider the following scenario :
> 
> - Node A take a write-exclusive persistent reservation on LU
> - Node B submits a write io to LU, which is a sda-sdb multipath
> - B dm_multipath routes the wio to sda, the wio is failed, the path is
> marked failed
> - B dm_multipath routes the wio to sdb, the wio is failed, the last
> path is marked failed
> - B queues the wio because of the queue_if_no_path feature. Process
> submitting the wio is stuck in D-state.
> - A releases the reservation. Queued wios are unqueued, corrupting the
> data on LU.
> 
> I suspect wio returning a "reservation conflict" status should never be
> queued.
> 
> DM suspend/resume on the multipath devmap effectively flushes the queue,
> but this solution leaves a window open for data corruption, between io
> enqueue and user-space driven queue flush.
> 
> Is there work in progress to address this issue yet ? What's would be an
> acceptable solution design (for example Mike Christie suggested in Aug
> 2005 a scsi-to-blk error translation patch, which got nowhere) ?
y of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

If memory serves, a SCSI command status of RESERVATION
CONFLICT did not find its way back to the sg driver API
(and/or the command was retried). Is that still the case?

Doug Gilbert

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-07-23 20:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19  8:59 persistent reservation behaviour with dm-multipath Christophe Varoqui
2008-07-23 20:28 ` Douglas Gilbert [this message]
2008-07-23 21:09   ` Christophe Varoqui
  -- strict thread matches above, loose matches on Subject: below --
2008-07-16 22:01 Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48879489.6060401@torque.net \
    --to=dougg@torque.net \
    --cc=christophe.varoqui@free.fr \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.