All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: joro@8bytes.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
	ed.pollard@ibm.com, epollard@redhat.com
Subject: Re: [PATCH]: PCI: GART iommu alignment fixes [v2]
Date: Thu, 24 Jul 2008 10:45:49 -0400	[thread overview]
Message-ID: <4888959D.6090907@redhat.com> (raw)
In-Reply-To: <4888925E.8050504@redhat.com>


>>>  
>>
>> Yeah, I'm not against fixing IOMMUs to make alloc_consistent return
>> the reqeuested size aligned memory. My point is that it's not likely
>> to fix anything. Even with the patch, we hit the above problem because
>> as I explained, the root cause of the problem is the boundary issue;
>> we need to fix pci-dma.c
>>
>>   
>
> Sorry, I misquoted code up there and was looking for a clear example 
> of where this would happen.  The issue I'm trying to resolve didn't 
> happen on the skge -- it was just a convenient piece of code to 
> examine and point out ;)
>

Here's a case where USB has problems:

 BIOS-e820: 0000000000000000 - 000000000009f400 (usable)
 BIOS-e820: 000000000009f400 - 00000000000a0000 (reserved)
 BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 00000000f57f6800 (reserved)
 BIOS-e820: 00000000f57f6800 - 00000000f5800000 (ACPI data)
 BIOS-e820: 00000000f5800000 - 00000000fdc00000 (reserved)
 BIOS-e820: 00000000fdc00000 - 00000000fdc01000 (reserved)
 BIOS-e820: 00000000fdc10000 - 00000000fdc01000 (reserved)
 BIOS-e820: 00000000fdc20000 - 00000000fdc01000 (reserved)
 BIOS-e820: 00000000fdc30000 - 00000000fdc01000 (reserved)
 BIOS-e820: 00000000fec00000 - 00000000fec10000 (reserved)
 BIOS-e820: 00000000fec10000 - 00000000fec20000 (reserved)
 BIOS-e820: 00000000fec20000 - 00000000fec30000 (reserved)
 BIOS-e820: 00000000fee00000 - 00000000fee10000 (reserved)
 BIOS-e820: 00000000fee10000 - 00000000ff800000 (reserved)
 BIOS-e820: 00000000ff800000 - 0000000100000000 (reserved)
 BIOS-e820: 0000000100000000 - 00000017fffff000 (usable)

I haven't tracked down what pci_alloc_consistent went wrong in 
usb-storage yet ... it seemed irrelevant because GART was broken.

P.

  parent reply	other threads:[~2008-07-24 15:10 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 11:19 [PATCH]: PCI: GART iommu alignment fixes [v2] Prarit Bhargava
2008-07-23 22:10 ` Joerg Roedel
2008-07-23 23:14   ` FUJITA Tomonori
2008-07-23 23:47     ` Prarit Bhargava
2008-07-24  7:46       ` Joerg Roedel
2008-07-24 10:09         ` Prarit Bhargava
2008-07-24 10:34           ` FUJITA Tomonori
2008-07-24 12:37             ` Joerg Roedel
2008-07-24 12:49               ` Prarit Bhargava
2008-07-24 13:32               ` FUJITA Tomonori
2008-07-24 14:31                 ` Prarit Bhargava
2008-07-24 14:40                   ` FUJITA Tomonori
2008-07-24 15:13                     ` Prarit Bhargava
2008-07-24 14:45                   ` Prarit Bhargava [this message]
2008-07-28 22:23     ` Jesse Barnes
2008-07-29 14:24       ` Prarit Bhargava
2008-07-29 17:08         ` Jesse Barnes
2008-07-30  0:43       ` FUJITA Tomonori
2008-08-06 12:29         ` Prarit Bhargava
2008-08-06 13:23           ` Prarit Bhargava
2008-08-06 13:35           ` FUJITA Tomonori
2008-08-06 14:32             ` Prarit Bhargava
2008-08-07 17:03               ` Jesse Barnes
2008-08-07 17:41                 ` Prarit Bhargava
2008-08-08  7:12                   ` Muli Ben-Yehuda
2008-08-08 15:18                     ` Prarit Bhargava
2008-08-08 16:15                       ` Jesse Barnes
2008-08-08 21:13                         ` FUJITA Tomonori
2008-08-09  1:40                           ` Prarit Bhargava
2008-08-09  3:50                   ` FUJITA Tomonori
2008-08-15 16:16                     ` Ingo Molnar
2008-08-15 18:00                       ` Ingo Molnar
2008-08-15 20:39                         ` Prarit Bhargava
2008-08-15 21:20                           ` Ingo Molnar
2008-08-16  1:15                         ` FUJITA Tomonori
2008-08-17 12:56                           ` Ingo Molnar
2008-08-17 15:36                             ` FUJITA Tomonori
2008-08-17 15:42                               ` Ingo Molnar
2008-08-17 15:48                                 ` FUJITA Tomonori
2008-08-17 15:54                                   ` FUJITA Tomonori
2008-08-07 17:45                 ` Prarit Bhargava
2008-07-23 23:23 ` FUJITA Tomonori
2008-07-23 23:24   ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4888959D.6090907@redhat.com \
    --to=prarit@redhat.com \
    --cc=ed.pollard@ibm.com \
    --cc=epollard@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jbarnes@virtuousgeek.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.