All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: jbarnes@virtuousgeek.org, joro@8bytes.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH]: PCI: GART iommu alignment fixes [v2]
Date: Wed, 06 Aug 2008 09:23:11 -0400	[thread overview]
Message-ID: <4899A5BF.1040802@redhat.com> (raw)
In-Reply-To: <4899993D.3060109@redhat.com>


>>
>>  
>>> @@ -265,7 +268,7 @@ static dma_addr_t dma_map_area(struct device 
>>> *dev, dma_addr_t phys_mem,
>>>  static dma_addr_t
>>>  gart_map_simple(struct device *dev, phys_addr_t paddr, size_t size, 
>>> int dir)
>>>  {
>>> -    dma_addr_t map = dma_map_area(dev, paddr, size, dir);
>>> +    dma_addr_t map = dma_map_area(dev, paddr, size, dir, size - 1);
>>>     
>
> Maybe I'm missing something -- what implies  size has to be a power of 
> two?
>
> P.
>

Ixnay that last comment -- I geddit (duh.).

The implication of "size-1" is that size is always a power of two.

Jesse -- I'll have to post a follow-up patch to fix this.

P.

  reply	other threads:[~2008-08-06 13:25 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 11:19 [PATCH]: PCI: GART iommu alignment fixes [v2] Prarit Bhargava
2008-07-23 22:10 ` Joerg Roedel
2008-07-23 23:14   ` FUJITA Tomonori
2008-07-23 23:47     ` Prarit Bhargava
2008-07-24  7:46       ` Joerg Roedel
2008-07-24 10:09         ` Prarit Bhargava
2008-07-24 10:34           ` FUJITA Tomonori
2008-07-24 12:37             ` Joerg Roedel
2008-07-24 12:49               ` Prarit Bhargava
2008-07-24 13:32               ` FUJITA Tomonori
2008-07-24 14:31                 ` Prarit Bhargava
2008-07-24 14:40                   ` FUJITA Tomonori
2008-07-24 15:13                     ` Prarit Bhargava
2008-07-24 14:45                   ` Prarit Bhargava
2008-07-28 22:23     ` Jesse Barnes
2008-07-29 14:24       ` Prarit Bhargava
2008-07-29 17:08         ` Jesse Barnes
2008-07-30  0:43       ` FUJITA Tomonori
2008-08-06 12:29         ` Prarit Bhargava
2008-08-06 13:23           ` Prarit Bhargava [this message]
2008-08-06 13:35           ` FUJITA Tomonori
2008-08-06 14:32             ` Prarit Bhargava
2008-08-07 17:03               ` Jesse Barnes
2008-08-07 17:41                 ` Prarit Bhargava
2008-08-08  7:12                   ` Muli Ben-Yehuda
2008-08-08 15:18                     ` Prarit Bhargava
2008-08-08 16:15                       ` Jesse Barnes
2008-08-08 21:13                         ` FUJITA Tomonori
2008-08-09  1:40                           ` Prarit Bhargava
2008-08-09  3:50                   ` FUJITA Tomonori
2008-08-15 16:16                     ` Ingo Molnar
2008-08-15 18:00                       ` Ingo Molnar
2008-08-15 20:39                         ` Prarit Bhargava
2008-08-15 21:20                           ` Ingo Molnar
2008-08-16  1:15                         ` FUJITA Tomonori
2008-08-17 12:56                           ` Ingo Molnar
2008-08-17 15:36                             ` FUJITA Tomonori
2008-08-17 15:42                               ` Ingo Molnar
2008-08-17 15:48                                 ` FUJITA Tomonori
2008-08-17 15:54                                   ` FUJITA Tomonori
2008-08-07 17:45                 ` Prarit Bhargava
2008-07-23 23:23 ` FUJITA Tomonori
2008-07-23 23:24   ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4899A5BF.1040802@redhat.com \
    --to=prarit@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jbarnes@virtuousgeek.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.